Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bug fixing and enhancements #71

Merged
merged 10 commits into from Feb 25, 2019

Conversation

Projects
None yet
2 participants
@PerrineGilloteaux
Copy link
Member

PerrineGilloteaux commented Feb 6, 2019

@miura @czhci could you validate?

@miura miura self-assigned this Feb 6, 2019

PerrineGilloteaux added some commits Feb 6, 2019

Adding link to create entries as a new page on field components or tr…
…aining materials, and avoid creating junk entries by errors
@PerrineGilloteaux

This comment has been minimized.

Copy link
Member Author

PerrineGilloteaux commented Feb 6, 2019

Please include the last 2 commits as well d97b6bf and af67871 in your review.

.gitignore Outdated
@@ -48,6 +48,7 @@ web/sites/simpletest
private
.env
.env-template
.lando.yml

This comment has been minimized.

@miura

miura Feb 21, 2019

Member

.lando.yml file should not be listed in .gitignore. This file is used by Lando to start up the server and needs to be the same among all developers. Please delete this line!

@miura
Copy link
Member

miura left a comment

.lando.yml file should be tracked, so please delete that line in .gitignore and then add & commit lando.yml file. Otherwise, I cannot test your branch (lando does not start).

@PerrineGilloteaux

This comment has been minimized.

Copy link
Member Author

PerrineGilloteaux commented Feb 22, 2019

@miura

This comment has been minimized.

Copy link
Member

miura commented Feb 22, 2019

Hi Kota , Yes but if someone start lando with a different name for example , it will be different for developers . And in addition this file is created by lando init, locally for the developper, there is no reason to edit it for all developers, is there?

@PerrineGilloteaux , yes, two reasons.

  • setting up local developing environment becomes even more complicated.
  • this pull request deletes lando file. All others including me need to restore lando.yml file after pulling this change.

It's free to change the name of lando instance but this then needs additional changes in other files to keep the Drupal running. Changes in the local is better be limited to minimal (such as env file, setting files). The trouble @czhci faced last month when she was trying to run the lando instance in her laptop, was actually this problem (now I understand).

This PR, as it is, will delete my .lando.yml file (already deleted mine in the test branch for this pull request). This will also happen to all others as well - which causes
lando start returning no /app found' error in all others.

Kota

Update .gitignore
Do not ignore lando.yml
@PerrineGilloteaux

This comment has been minimized.

Copy link
Member Author

PerrineGilloteaux commented Feb 25, 2019

Hi Kota ,I ve edited the .gitignore

@miura

This comment has been minimized.

Copy link
Member

miura commented Feb 25, 2019

Add back Lando yml file
Warning: this file is dependant of your lando init command, it will be modified locally if you choose a name different from bisescratch.
@PerrineGilloteaux

This comment has been minimized.

Copy link
Member Author

PerrineGilloteaux commented Feb 25, 2019

Hi @miura ,lando.yml is back.
Note that the comment bug is fixed in drupal 8.6.10 (see #69 ), I will commit it and do a new PR, once this one is deployed.

@miura miura merged commit fba2eb7 into NeuBIAS:dev Feb 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.