Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Some bug fixing and enhancements #71
Hi Kota , Yes but if someone start lando with a different name for example , it will be different for developers . And in addition this file is created by lando init, locally for the developper, there is no reason to edit it for all developers, is there?…
Le 22 févr. 2019 à 00:16, Kota Miura ***@***.***> a écrit : @miura commented on this pull request. In .gitignore: > @@ -48,6 +48,7 @@ web/sites/simpletest private .env .env-template +.lando.yml .lando.yml file should not be listed in .gitignore. This file is used by Lando to start up the server and needs to be the same among all developers. Please delete this line! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
@PerrineGilloteaux , yes, two reasons.
It's free to change the name of lando instance but this then needs additional changes in other files to keep the Drupal running. Changes in the local is better be limited to minimal (such as env file, setting files). The trouble @czhci faced last month when she was trying to run the lando instance in her laptop, was actually this problem (now I understand).
This PR, as it is, will delete my .lando.yml file (already deleted mine in the test branch for this pull request). This will also happen to all others as well - which causes
Great, could you also add back lando.yml? You can find the original in Github.…
On Mon 25. Feb 2019 at 09:20, Perrine Paul-Gilloteaux < ***@***.***> wrote: Hi Kota ,I ve edited the .gitignore — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQpjbKY9qTt0_dDdkcDx290HmzQ1236ks5vQ5zmgaJpZM4alHYX> .