New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brian imports to use brian2 #617

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@sanjayankur31
Copy link
Contributor

sanjayankur31 commented Dec 6, 2018

All the brian documentation says import brian2, so that's what we
should use too.

https://brian2.readthedocs.io/en/stable/resources/tutorials/1-intro-to-brian-neurons.html

Update brian imports to use brian2
All the brian documentation says `import brian2`, so that's what we
should use too.
@apdavison

This comment has been minimized.

Copy link
Member

apdavison commented Dec 6, 2018

I wish it was so simple. Unfortunately, Brian 2 is not 100% backwards compatible with Brian 1, or at least, PyNN relies on internal implementation details of Brian 1. @appukuttan-shailesh is working on a Brian 2 backend.

@apdavison apdavison closed this Dec 6, 2018

@sanjayankur31

This comment has been minimized.

Copy link
Contributor Author

sanjayankur31 commented Dec 6, 2018

Ugh, I hadn't realised that. So, if one wants to use pynn with brian, they also need to have brian1 installed?

@sanjayankur31

This comment has been minimized.

Copy link
Contributor Author

sanjayankur31 commented Dec 6, 2018

If so, we should probably document this. Folks installing brian2 from source will be in for a couple of surprises otherwise :/

@sanjayankur31

This comment has been minimized.

Copy link
Contributor Author

sanjayankur31 commented Dec 6, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 8, 2018

Coverage Status

Coverage decreased (-8.1%) to 54.569% when pulling d4daf62 on sanjayankur31:update-brian-import into 3392560 on NeuralEnsemble:master.

@rgerkin

This comment has been minimized.

Copy link
Contributor

rgerkin commented Jan 23, 2019

@appukuttan-shailesh Is there a timeline for a Brian2 backend?

@appukuttan-shailesh

This comment has been minimized.

Copy link
Contributor

appukuttan-shailesh commented Jan 23, 2019

No definite timeline as of now, but hoping for an initial release in 2-3 months.
(been wanting to redirect time and efforts towards this since a long time!)

@sanjayankur31

This comment has been minimized.

Copy link
Contributor Author

sanjayankur31 commented Jan 23, 2019

If there's some sort of task list of what needs to be done, a few of us could help?

@appukuttan-shailesh

This comment has been minimized.

Copy link
Contributor

appukuttan-shailesh commented Jan 23, 2019

@sanjayankur31 : Thanks! That could be helpful. I will try to upload a minimal working version (that I have started on) in the next 2 (max 3?!) weeks, so that we all have something to build on. Once that is done, I will upload a list of sub-tasks that need to be taken up. I would be happy to have you and others pick from these and contribute.

@sanjayankur31

This comment has been minimized.

Copy link
Contributor Author

sanjayankur31 commented Jan 23, 2019

That would be brilliant. I'm sure I (and others) would be happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment