Use correct comparison operator #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're comparing values here, "==" or "!=" should be used. "is" compares identities.
|
good spot! |
|
Came up in the Fedora package review: https://bugzilla.redhat.com/show_bug.cgi?id=1150105 I'm just going through the other notes there now. Hopefully we'll have PyNN in NeuroFedora before the end of the week so we can mark it as a featured tool for the next Fedora release (in a few months time). |
|
thats great. Many thanks for all this work @sanjayankur31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak: since we're comparing values here, "==" or "!=" should be used. ("is" compares identities).