Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add_hyperparams() and not just set_hyperparams() #194

Open
guillaume-chevalier opened this issue Nov 18, 2019 · 2 comments
Open

Feature: add_hyperparams() and not just set_hyperparams() #194

guillaume-chevalier opened this issue Nov 18, 2019 · 2 comments

Comments

@guillaume-chevalier
Copy link
Member

@guillaume-chevalier guillaume-chevalier commented Nov 18, 2019

This is in the case we want to override just 1 param and not each one. I thought this was done by default in the set method until I faced a bug.

TODO: we might find a better name than add_hyperparams. Perhaps add a flag to the setter, like set_hyperparams(..., update=True) where update will call self.hyperparams.update(new_hyperparams) instead of overriding them.

@guillaume-chevalier

This comment has been minimized.

Copy link
Member Author

@guillaume-chevalier guillaume-chevalier commented Nov 21, 2019

note: the random search and AutoML loops should use add params rather than set params, because sometimes there might miss some spaces or distributions so when that happens, we'd need not to overwrite the existing default params (those who don't have spaces).

@alexbrillant

@alexbrillant

This comment has been minimized.

Copy link
Member

@alexbrillant alexbrillant commented Nov 27, 2019

Fixed here #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.