Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature: add_hyperparams() and not just set_hyperparams() #194
Labels
Comments
This comment has been minimized.
This comment has been minimized.
note: the random search and AutoML loops should use add params rather than set params, because sometimes there might miss some spaces or distributions so when that happens, we'd need not to overwrite the existing default params (those who don't have spaces). |
This comment has been minimized.
This comment has been minimized.
Fixed here #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is in the case we want to override just 1 param and not each one. I thought this was done by default in the
set
method until I faced a bug.TODO: we might find a better name than
add_hyperparams
. Perhaps add a flag to the setter, likeset_hyperparams(..., update=True)
where update will callself.hyperparams.update(new_hyperparams)
instead of overriding them.