Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid: Fix `p.save(ExecutionContext(p, FIT, "./path/")` to just `p.save(ExecutionContext("./path/")` #196

Closed
guillaume-chevalier opened this issue Nov 21, 2019 · 0 comments
Assignees
Milestone

Comments

@guillaume-chevalier
Copy link
Member

@guillaume-chevalier guillaume-chevalier commented Nov 21, 2019

@alexbrillant
Invalid: Fix p.save(ExecutionContext(p, FIT, "./path/") to just p.save(ExecutionContext("./path/")

Implications:

  1. We must add a hook before each of the handler methods to push themselves into the context, like context.push(self) before handling.
  2. Each class that is a MetaStep and each TruncableStep must not anymore push the substeps in the context before passing the context to the substeps.

This is a major change as it might require a refactor of every or most of the projects using Neuraxle.

@guillaume-chevalier guillaume-chevalier added this to the 0.3.0 milestone Nov 21, 2019
alexbrillant added a commit to alexbrillant/Neuraxle that referenced this issue Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.