Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReversiblePreprocessingWrapper #59

Closed
guillaume-chevalier opened this issue Sep 16, 2019 · 4 comments
Closed

ReversiblePreprocessingWrapper #59

guillaume-chevalier opened this issue Sep 16, 2019 · 4 comments
Labels

Comments

@guillaume-chevalier
Copy link
Member

@guillaume-chevalier guillaume-chevalier commented Sep 16, 2019

We'll need something like this:

class ReversiblePreprocessingWrapper(MetaStepMixin, BaseStep): 
    def __init__(
        self, 
        wrapped_step: BaseStep, 
        reversible_preprocessing_pipeline: BaseStep
    ):
        pass  # ...

    def transform(self, data_inputs): 
        data_inputs = self.reversible_preprocessing_pipeline.transform(data_inputs)
        data_inputs = self.wrapped_step.transform(data_inputs)
        data_inputs = self.reversible_preprocessing_pipeline.inverse_transform(data_inputs)
        return data_inputs
@guillaume-chevalier

This comment has been minimized.

Copy link
Member Author

@guillaume-chevalier guillaume-chevalier commented Nov 1, 2019

@alexbrillant Is this still in our other project, or is this committed here?

@guillaume-chevalier

This comment has been minimized.

Copy link
Member Author

@guillaume-chevalier guillaume-chevalier commented Nov 21, 2019

@alexbrillant what's the status for our ReversiblePreprocessingWrapper and normalizer? (this is the 1, 2, reversed(1) thing as we discussed, where 1 is the normalization, and 2 is the wrapped seq2seq model).

Related: jaungiers/LSTM-Neural-Network-for-Time-Series-Prediction#60

@alexbrillant

This comment has been minimized.

Copy link
Member

@alexbrillant alexbrillant commented Nov 22, 2019

@guillaume-chevalier I think it is committed in another repository

@alexbrillant

This comment has been minimized.

Copy link
Member

@alexbrillant alexbrillant commented Nov 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.