Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniBatchSequentialPipeline & Joiner previously called Streaming pipeline #87

Merged
merged 14 commits into from Oct 3, 2019

Conversation

@alexbrillant
Copy link
Member

commented Sep 30, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2019
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
@alexbrillant alexbrillant requested a review from guillaume-chevalier Oct 1, 2019
@alexbrillant alexbrillant requested a review from Vaunorage Oct 1, 2019
Copy link
Member

left a comment

Overall the sequential class is too big and some logic must go in the barriers (e.g.: a joiner step).

neuraxle/base.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
testing/test_minibatch_sequential_pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
@alexbrillant alexbrillant changed the title Discussion/Wip MiniBatchSequentialPipeline previously called Streaming pipeline MiniBatchSequentialPipeline & Joiner previously called Streaming pipeline Oct 2, 2019
neuraxle/base.py Show resolved Hide resolved
neuraxle/base.py Outdated Show resolved Hide resolved
neuraxle/base.py Show resolved Hide resolved
neuraxle/base.py Show resolved Hide resolved
neuraxle/base.py Show resolved Hide resolved
neuraxle/base.py Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Outdated Show resolved Hide resolved
neuraxle/pipeline.py Show resolved Hide resolved
neuraxle/pipeline.py Show resolved Hide resolved
alexbrillant added 4 commits Oct 2, 2019
neuraxle/base.py Outdated Show resolved Hide resolved
@alexbrillant

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@guillaume-chevalier merged conflicts & fixed handle_transform comment on the non fittable mixin

@guillaume-chevalier guillaume-chevalier merged commit ddc7ee8 into Neuraxio:dev Oct 3, 2019
1 check passed
1 check passed
verification/cla-signed
Details
@guillaume-chevalier

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

@alexbrillant is there an issue to close for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.