Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pdf and cdf to continuous distribution #94

Open
wants to merge 5 commits into
base: master
from

Conversation

@Eric2Hamel
Copy link
Collaborator

commented Oct 3, 2019

Add pdf and cdf to uniform distribution

Add pdf and cdf to uniform distribution
@cla-bot cla-bot bot added the cla-signed label Oct 3, 2019
Copy link
Member

left a comment

Thank you! I only have 2 comments before continuing this.

neuraxle/hyperparams/distributions.py Outdated Show resolved Hide resolved
neuraxle/hyperparams/distributions.py Outdated Show resolved Hide resolved
@Eric2Hamel Eric2Hamel changed the title Add pdf and cdf to uniform distribution Add pdf and cdf to continuous distribution Oct 12, 2019
@Eric2Hamel

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 12, 2019

I have done the pdf and cdf for the continuous distribution. I will have to do the pdf and cdf for the discrete distribution. Do each discrete probabilities has to implement a probability? Like Boolean do I had a proba so True happens with proba and False happens with (1 - proba). Or do I implement only a pChoice?

Copy link
Member

left a comment

Nice work! :)

Here is my review.

neuraxle/hyperparams/distributions.py Show resolved Hide resolved
neuraxle/hyperparams/distributions.py Show resolved Hide resolved
neuraxle/hyperparams/distributions.py Show resolved Hide resolved
neuraxle/hyperparams/distributions.py Show resolved Hide resolved
@guillaume-chevalier

This comment has been minimized.

Copy link
Member

commented Oct 12, 2019

@Eric2Hamel to answer your question:

I have done the pdf and cdf for the continuous distribution. I will have to do the pdf and cdf for the discrete distribution. Do each discrete probabilities has to implement a probability? Like Boolean do I had a proba so True happens with proba and False happens with (1 - proba). Or do I implement only a pChoice?

I'm not sure, I'd advise for getting inspiration from the way the scipy.stats distributions work and do something similar.

@guillaume-chevalier

This comment has been minimized.

Copy link
Member

commented Oct 18, 2019

I'm not sure, I'd advise for getting inspiration from the way the scipy.stats distributions work and do something similar.

@Eric2Hamel Edit: in fact I didn't understand what you meant. Now that's clear after having further discussed that, and opening Issue #115! Let's do this later, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.