Skip to content

Consolidate logging (and other minor tweaks) #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 6, 2021
Merged

Consolidate logging (and other minor tweaks) #112

merged 22 commits into from
Jul 6, 2021

Conversation

@sanjayankur31
Copy link
Member

  • uses logging where appropriate,
  • removes print_comment_v, and makes print_comment the default pretty printed comment function. It'll always print. For debuginfo and warnings and so on, we use the loggers.

@sanjayankur31
feat: use logging module in pynml.py
e2fef61
@sanjayankur31
feat: use print_comment for mandatory messages
51451a0
@sanjayankur31
feat: replace print_comment_v
8fc45b2
@sanjayankur31
chore: add mypy config
5a0ad28 
Make it ignore packages where type information is not available
@sanjayankur31
feat: replace print_comment_v function
2b61f98
@sanjayankur31
feat: update logging
4c5c12d
@sanjayankur31
feat: replace print_comment_v
0502a2c 
Also update links to schema docs
@sanjayankur31
feat: replace print_comment_v
6301e7c
@sanjayankur31
chore: convert to Linux file endings
2a83dda
@sanjayankur31
feat: replace with logging
a1b00c7
@sanjayankur31
feat: replace print_comment_v function
6acc721
@sanjayankur31
feat: use consistent logging
ad6096b
@sanjayankur31
feat: update logging
e72143e
@sanjayankur31
feat: use logger
abf0399
@sanjayankur31
feat: move logging to package init
d2464da
@sanjayankur31
refactor: replace print_comment_v function
745113a
@sanjayankur31
refactor: remove print_comment_v function
6a0f42f
@sanjayankur31
refactor: use logging
93ef3f8
@sanjayankur31
refactor: remove print_comment_v function
7bffb0f
@sanjayankur31
refactor: remove print_comment_v function
788c16b
@sanjayankur31
chore: convert to unix line endings
dba3a98
@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Jul 5, 2021
@sanjayankur31 sanjayankur31 self-assigned this Jul 5, 2021
@sanjayankur31 sanjayankur31 linked an issue Jul 5, 2021 that may be closed by this pull request
Replace print_comment* methods with a logging class implementation #106
Closed
@sanjayankur31
Copy link
Member Author

Refactoring, mostly with cosmetic changes. All tests pass, so confirmation that this hasn't broken any functionality. Merging (so I can open more PRs, which will otherwise conflict with this one).

@sanjayankur31 sanjayankur31 merged commit 0b645d6 into development Jul 6, 2021
@sanjayankur31 sanjayankur31 deleted the feat/use-logging branch July 6, 2021 09:41
@pgleeson
Copy link
Member

pgleeson commented Jul 6, 2021

Thanks @sanjayankur31 . From a qucik test I see that the output from jnml, which had been displayed by default when run in pynml does not show any more. This is useful debugging info. Can you change that?

@sanjayankur31
Copy link
Member Author

Sure---since it is debugging info, it can be seen when -v INFO or -v DEBUG are provided. Do we always want this info to be always shown to users?

@sanjayankur31
Copy link
Member Author

If a command fails, it will be printed: these are at the CRITICAL level. For example: https://github.com/NeuroML/pyNeuroML/blob/development/pyneuroml/pynml.py#L1649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sanjayankur31 sanjayankur31

Labels

T: enhancement Type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace print_comment* methods with a logging class implementation

3 participants

@sanjayankur31 @pgleeson