Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

narrow the definition of a scalar dataset #431

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

lawrence-mbf
Copy link
Collaborator

Fixes #430

How to test the behavior?

Export the following timeseries:

ts = types.core.TimeSeries( ...
            'data', 12.3, ...
            'description', 'XYZ', ...
            'data_unit', 'time', ...
            'timestamps', 12.3);

However you validate it, the space must be using a non-scalar space specification.

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@lawrence-mbf lawrence-mbf requested a review from bendichter May 23, 2022 14:43
@lawrence-mbf lawrence-mbf marked this pull request as draft May 23, 2022 14:44
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #431 (d4a3bc7) into master (8fc2589) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   85.97%   86.01%   +0.03%     
==========================================
  Files         125      125              
  Lines        5070     5070              
==========================================
+ Hits         4359     4361       +2     
+ Misses        711      709       -2     
Impacted Files Coverage Δ
+io/writeCompound.m 81.48% <ø> (ø)
+file/isShapeScalar.m 87.50% <100.00%> (ø)
+file/fillExport.m 98.47% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc2589...d4a3bc7. Read the comment docs.

@lawrence-mbf lawrence-mbf marked this pull request as ready for review May 23, 2022 15:51
@lawrence-mbf lawrence-mbf merged commit 70bed03 into master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:
1 participant