Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements, drop Python 2.7 support #1028

Merged
merged 6 commits into from Aug 1, 2019

Conversation

@rly
Copy link
Contributor

rly commented Jul 30, 2019

This PR:

  • drops continuous integration testing for Python 2.7
  • updates documentation
  • updates pinned versions of required packages
rly added 2 commits Jul 30, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #1028 into dev will decrease coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1028      +/-   ##
==========================================
- Coverage   73.26%   72.48%   -0.78%     
==========================================
  Files          36       36              
  Lines        2734     2733       -1     
  Branches      523      523              
==========================================
- Hits         2003     1981      -22     
- Misses        615      635      +20     
- Partials      116      117       +1
Impacted Files Coverage Δ
src/pynwb/ogen.py 93.1% <0%> (-6.9%) ⬇️
src/pynwb/behavior.py 95.34% <0%> (-4.66%) ⬇️
src/pynwb/retinotopy.py 95.34% <0%> (-4.66%) ⬇️
src/pynwb/image.py 91.42% <0%> (-2.86%) ⬇️
src/pynwb/ecephys.py 94.69% <0%> (-2.68%) ⬇️
src/pynwb/misc.py 84.25% <0%> (-1.86%) ⬇️
src/pynwb/icephys.py 87.5% <0%> (-1.79%) ⬇️
src/pynwb/base.py 90.9% <0%> (-1.52%) ⬇️
src/pynwb/ophys.py 93.38% <0%> (-1.48%) ⬇️
src/pynwb/file.py 78.22% <0%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b010af...68e4f5b. Read the comment docs.

@rly

This comment has been minimized.

Copy link
Contributor Author

rly commented Jul 30, 2019

Python 2.7 tests fail because the latest numpy and pandas versions on PyPI do not support Python 2.7. See #933 on when to remove Python 2.7 support in PyNWB.

I have extracted the HDMF-only update to requirements.txt to #1030.

ajtritt and others added 4 commits Jul 31, 2019
@rly rly changed the title Update requirements to latest versions, incl HDMF Update requirements, drop Python 2.7 support Aug 1, 2019
@rly rly requested a review from ajtritt Aug 1, 2019
@ajtritt
ajtritt approved these changes Aug 1, 2019
Copy link
Member

ajtritt left a comment

                                               _ 
    /\                                        | |
   /  \__      _____  ___  ___  _ __ ___   ___| |
  / /\ \ \ /\ / / _ \/ __|/ _ \| '_ ` _ \ / _ \ |
 / ____ \ V  V /  __/\__ \ (_) | | | | | |  __/_|
/_/    \_\_/\_/ \___||___/\___/|_| |_| |_|\___(_)
@rly rly merged commit 6e34fc4 into dev Aug 1, 2019
20 checks passed
20 checks passed
NeurodataWithoutBorders.pynwb Build #20190801.12 succeeded
Details
NeurodataWithoutBorders.pynwb (Dummy) Dummy succeeded
Details
NeurodataWithoutBorders.pynwb (Test PyNWB Windows-py3.5) Test PyNWB Windows-py3.5 succeeded
Details
NeurodataWithoutBorders.pynwb (Test PyNWB Windows-py3.6) Test PyNWB Windows-py3.6 succeeded
Details
NeurodataWithoutBorders.pynwb (Test PyNWB Windows-py3.7) Test PyNWB Windows-py3.7 succeeded
Details
NeurodataWithoutBorders.pynwb (Test PyNWB macOS-py3.5) Test PyNWB macOS-py3.5 succeeded
Details
NeurodataWithoutBorders.pynwb (Test PyNWB macOS-py3.6) Test PyNWB macOS-py3.6 succeeded
Details
NeurodataWithoutBorders.pynwb (Test PyNWB macOS-py3.7) Test PyNWB macOS-py3.7 succeeded
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: gallery35 Your tests passed on CircleCI!
Details
ci/circleci: gallery36 Your tests passed on CircleCI!
Details
ci/circleci: gallery37 Your tests passed on CircleCI!
Details
ci/circleci: miniconda35 Your tests passed on CircleCI!
Details
ci/circleci: miniconda36 Your tests passed on CircleCI!
Details
ci/circleci: miniconda37 Your tests passed on CircleCI!
Details
ci/circleci: python35 Your tests passed on CircleCI!
Details
ci/circleci: python36 Your tests passed on CircleCI!
Details
ci/circleci: python37 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 8b010af...68e4f5b
Details
codecov/project 72.48% (-0.78%) compared to 8b010af
Details
@rly rly deleted the update_reqs branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.