This repository has been archived by the owner on Jul 1, 2019. It is now read-only.
Handle when one of username or password is missing #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authorization requires an API key, or username/password combination. Current implementation covers checking for both user and password, neither username or password, but fails to check for cases where a username is offered but a password isn't. This commit fixes that and also provides more detailed error messages. Added bonus, exceptions are now thrown BEFORE curl is initialized.
Nevon
added a commit
that referenced
this pull request
Mar 21, 2015
Handle when one of username or password is missing
|
Thank you for your contribution! |
|
No problem. I'll probably have some more as I build out Marketo's setup. |
|
Excellent! As you can see from the commit history, I wrote this lib 3 years ago and haven't used it since. I've been meaning to clean it up, add unit tests, etc. but I haven't had much motivation to do so, as I don't use the lib myself. So, any contributions are more than welcome. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authorization requires an API key, or username/password combination.
Current implementation covers checking for both user and password, neither username or password, but fails to check for cases where a username is offered but a password isn't. This commit fixes that and also provides more detailed error messages. Added bonus: exceptions are now thrown BEFORE curl is initialized.