Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamped pipes in rotated or mirrored blueprints #2

Closed
0ptera opened this issue Nov 22, 2018 · 9 comments
Closed

clamped pipes in rotated or mirrored blueprints #2

0ptera opened this issue Nov 22, 2018 · 9 comments
Assignees

Comments

@0ptera
Copy link

0ptera commented Nov 22, 2018

When rotating or mirroring a blueprint with clamped pipes the result is a mess.

Original:
2018-11-22-12-33-18-1706623

Rotated 90°:
2018-11-22-12-38-03-1866501

Rotated 180°:
2018-11-22-12-33-29-5500361

Mirrored:
2018-11-22-12-33-36-1831528

As much as I'd love to get rid of flow control and use this instead without blueprint support it's almost useless to me.

@TheStaplergun
Copy link
Collaborator

I will have to see what sort of event is fired when the blueprint rotates and cause a rotation of the clamps. They're just pipes, and pipes don't rotate.

@TheStaplergun
Copy link
Collaborator

I have a solution. Gonna require a rework of the prototypes. Thanks for submitting the issue and please be patient! Might take me a bit, it's Thanksgiving weekend.

@0ptera
Copy link
Author

0ptera commented Nov 22, 2018

Take your time, I didn't expect a fix within the hour.

Would be nice if in the process you could shrink down pipe prototypes to straight, curve, T and X and rotate those instead of having one per rotation. Currently this adds a lot of prototypes to select in deconstruction planner.

@TheStaplergun
Copy link
Collaborator

That's actually, funny enough, gonna be one of the benefits of the rework. Glad I could solve two problems at once.

@Nexela
Copy link
Owner

Nexela commented Nov 22, 2018 via email

@TheStaplergun
Copy link
Collaborator

It actually should correct itself with this change, because the type it's being changed to can be mirrored properly.

@TheStaplergun
Copy link
Collaborator

I've gotten the changes written. Im not sure if mirroring will work properly for elbow bend pipes. The mod owner for that might have to change it.
What I have written now will work though you'll have to go through and place your blueprints and reclamp all the pipes with the new ones, then blueprint that. They'll rotate properly now though.

Any pipes currently in the world from the old entity will be auto-replaced with the new version for you.

Do you have a copy of your save you can upload so I can test and ensure that the fix works in your map without problems?

@TheStaplergun TheStaplergun self-assigned this Nov 23, 2018
@TheStaplergun
Copy link
Collaborator

Fixed in 57fbc91

Set up to properly support in blueprint mirroring in
Nexela/PickerExtended@e98eef6

@TheStaplergun
Copy link
Collaborator

Both mods have been updated in mod portal containing the above fixes and other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants