Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SMAPI not enabled diagnostic #1674

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix SMAPI not enabled diagnostic #1674

merged 1 commit into from
Jun 24, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jun 24, 2024

Resolves #1672.

@erri120 erri120 requested a review from a team June 24, 2024 11:39
@erri120 erri120 self-assigned this Jun 24, 2024
@erri120 erri120 changed the title Fix SMAPI not disabled diagnostic Fix SMAPI not enabled diagnostic Jun 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.79%. Comparing base (2e72a5f) to head (95beaec).

Current head 95beaec differs from pull request most recent head dc980b8

Please upload reports for the commit dc980b8 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1674       +/-   ##
=========================================
+ Coverage      0   48.79%   +48.79%     
=========================================
  Files         0      769      +769     
  Lines         0    26664    +26664     
  Branches      0     2025     +2025     
=========================================
+ Hits          0    13011    +13011     
- Misses        0    13249    +13249     
- Partials      0      404      +404     
Flag Coverage Δ
Windows 48.66% <0.00%> (?)
clean_environment_tests 48.77% <0.00%> (?)
macOS 48.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ames.StardewValley/Emitters/MissingSMAPIEmitter.cs 0.00% <0.00%> (ø)

... and 768 files with indirect coverage changes

@erri120 erri120 merged commit 183bf15 into Nexus-Mods:main Jun 24, 2024
11 checks passed
@erri120 erri120 deleted the fix/1672 branch June 24, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Stardew Valley - Multiple installs of SMAPI cause unexpected diagnostics
3 participants