Fix app not disposing service host correctly #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service definition order is used to determine the order of `StartAsync()` calls. Inverse order is used for `StopAsync()`.
…) downloads before application close. Business logic such as pausing/cancelling downloads should happen in StopAsync rather than DisposeAsync. Converting this to IHostedService also means that the class is instantiated before StartAsync is called on the Host, meaning that DB connection would not be initialized. DB related logic had to regrettably be moved to StartAsync instead, where DB would be available and initialized already.
erri120
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing app with ongoing downloads caused infinite hang, had to make several adjustments to get the app to close cleanly for now.
Downloads are currently cancelled on close, fixing that will require more involved changes for another PR.
See commit messages for details on reasons for some of the changes.
Open to suggestions for better approaches as I'm not necessarily convinced this to be the best solution.