Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler NXM link handling #1683

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Simpler NXM link handling #1683

merged 3 commits into from
Jun 25, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jun 25, 2024 •
edited
Loading

I highjacked the CommandLineConfigurator to handle the case where we get a single URI argument that we can handle.

Resolves #1677.

@erri120 erri120 requested review from halgari, Sewer56 and Al12rs June 25, 2024 09:08
@erri120 erri120 self-assigned this Jun 25, 2024
@erri120
Copy link
Member Author

erri120 commented Jun 25, 2024

This'll probably break some tests

Al12rs
Al12rs requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test yet, did you already test on windows?

@erri120
Copy link
Member Author

erri120 commented Jun 25, 2024

Didn't test yet, did you already test on windows?

The behavior on Windows hasn't changed, it'll still use the protocol-invoke --url %u command.

Al12rs
Al12rs requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, comment was not submitted

src/NexusMods.SingleProcess/CommandLineConfigurator.cs Show resolved Hide resolved
@erri120 erri120 requested a review from Al12rs June 25, 2024 09:43
@erri120 erri120 merged commit 186b4b8 into Nexus-Mods:main Jun 25, 2024
12 checks passed
@erri120 erri120 deleted the feat/1677 branch June 25, 2024 13:55
@MattSturgeon MattSturgeon mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al12rs Al12rs Al12rs approved these changes

@halgari halgari Awaiting requested review from halgari

@Sewer56 Sewer56 Awaiting requested review from Sewer56

Assignees

@erri120 erri120

Labels
None yet
Projects
MVP
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify protocol handler
2 participants
@erri120 @Al12rs