Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored XSS when deleting proxy host #1950

Closed
l4rm4nd opened this issue Mar 24, 2022 · 2 comments
Closed

Stored XSS when deleting proxy host #1950

l4rm4nd opened this issue Mar 24, 2022 · 2 comments
Labels

Comments

@l4rm4nd
Copy link

@l4rm4nd l4rm4nd commented Mar 24, 2022

Steps to reproduce:

  1. Login as administrative user
  2. Create a new proxy host entry with the payload <script>alert('XSS')</script>.google.com as domain
  3. Hit save
  4. Try to delete the newly added proxy host. XSS payload is executed.

image

image

image

Recommendation:

Implementing input validation and/or ensuring output sanitization as done for all other inputs/outputs.

Risk:

Low risk since high privileges are required.

@l4rm4nd l4rm4nd added the bug label Mar 24, 2022
@l4rm4nd
Copy link
Author

@l4rm4nd l4rm4nd commented Mar 24, 2022

Also works for redirection hosts with XSS domain payloads. If a redirection host is deleted, XSS payload is executed.

jc21 added a commit that referenced this issue Mar 24, 2022
Fix #1950 attempt to encode hdomain values before render
@jc21
Copy link
Member

@jc21 jc21 commented Mar 24, 2022

Thanks for the pickup.

Fixed in develop branch and will be out with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants