-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added crowdsec openresty bouncer support #2677
base: develop
Are you sure you want to change the base?
Added crowdsec openresty bouncer support #2677
Conversation
Docker Image for build 2 is available on DockerHub as Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes. |
@LePresidente can I just use: jc21/nginx-proxy-manager:github-pr-2677 to test the PR? |
use this lepresidente/nginxproxymanager:latest as it requires a change in the base image |
I had your image running for a long time but after a recent update I am not able to get this back into a running state. I am using this image: lepresidente/nginx-proxy-manager and I've configured the image to point to my existing data (which works with jc21's original image). What I am seeing from the logs are this (which keeps on repeating): |
Having found this pull request and updated my docker to use the image you stated above I am now presented with a different error: [3/28/2023] [10:18:02 PM] [SSL ] › ✖ error Error: Command failed: certbot renew --non-interactive --quiet --config "/etc/letsencrypt.ini" --preferred-challenges "dns,http" --disable-hook-validation |
Manually executing this: pip3 install certbot-dns-cloudflare removes the error and the log states: [3/28/2023] [10:41:15 PM] [Global ] › ℹ info Backend PID 106 listening on port 3000 ... I am not able to log in though using either my original username/password or admin@example. |
ok so this was my image for https://github.com/jlesage/docker-nginx-proxy-manager which is a fork of this that was done for unraid, and dont think they compatible to interchange so you need to switch back. I'll have to see why its failing or if there is a change upstream since he reworked how the image was built which might of broken things |
@pittbull please try the latest image from here for the /jlesage/docker-nginx-proxy-manager image lepresidente/nginx-proxy-manager:dev |
Using :dev on a replica of the original NPM folder did the trick. Came right up! This has crowdsec, right? How about modsec? |
@LePresidente, your image works perfectly, but i am experiencing problems with cloudflare SSL certificates. Here is the error I got.... |
Hey Laurence from crowdsec support. I can see there is a lot of interaction on this PR, I do not know the project very well. Will this be something that will be merged or will user have to rely on forks? |
I migrated my proxy manager to traefik, but its could be nice to get the original proxy manager with crowdsec. |
something went wrong yesterday when i tried to update my fork, i'll need to look into this and amybe redo a new squashed commit |
I'm going to clean this up and close this PR and open a new one. |
dc5c132
to
7705728
Compare
There seem to be a bit of confusion on the various versions available. @LePresidente could you update me which image to now use and if this will get updated along the master image? |
Yeah same for me, I still use the old "baudneo" one, and I really want a more up-to-date version. |
Lepresidente/nginx-proxy-manager = jlesange/nginx-proxy-manager (up-to-date) (unraid fork I use) They are inplace replacements for the official images. didn't mean to delete the comment |
Should be nice to see something like this added. |
Any chance this will be added? |
Edit: never mind, the error is also present in the original base image: #3592 @LePresidente I still use your "Lepresidente/nginxproxymanager" version and just did a docker pull. And now the image won't start with error:
Any idea? |
Is there any chance that this gets worked on? |
@jrpetersjr I mean it just needs to be tested and merged by the maintainer, I don't think there have been any real complaint from people using my builds that basically includes this PR and NginxProxyManager/docker-nginx-full#8 |
i am using it for ages, in production and public facing stuff. |
Re Opened old PR that was closed due to force sync on develop branch
#1875
This adds support for Nginx Proxy Manager to be a firewall bouncer for Crowdsec
Blog post on what this does
https://crowdsec.net/blog/nginx-bouncer-v1/
This has been expanded to be a permanent addon to Nginx Proxy Manager,
This requires the following changes to the base image
NginxProxyManager/docker-nginx-full#7
There are three Configurations that would be needed to be configurable from Nginx Proxy Manager to configure the crowdsec-openresty-bouncer for the bare minimum to get it working
File: /data/crowdsec/crowdsec-openresty-bouncer.conf
I'm not really sure how to do the frontend, if I can get some guidance I could do it as well
This is also currently a global setting so if an IP is banned it won't be able to connect to any host.
Full config for crowdsec