Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nheko room directory #659

Merged
merged 18 commits into from Aug 17, 2021
Merged

Nheko room directory #659

merged 18 commits into from Aug 17, 2021

Conversation

kamathmanu
Copy link
Contributor

@kamathmanu kamathmanu commented Jul 29, 2021 •
edited

Closes #328 with an initial version of the Room Directory. This branch is the completed/restructured changes of my [original PR] (#496) since that one has some issues due to bad auto-merges.

Features planned for room directory extension

  1. Including ability for users to specify server and network/protocols to search on (ideally with a dropdown/text-input combo UI)
  2. Aesthetics (particularly to make the room information like number of members more intuitive/easily understandable)
  3. Preview-ability

LorenDB
LorenDB reviewed Aug 8, 2021
View reviewed changes
Copy link
Member

@LorenDB LorenDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. I didn't mark all of the Math.ceil instances in here.

I'd also suggest a loading spinner to show the user that rooms are loading. Other than that, I like it.

CMakeLists.txt Outdated Show resolved Hide resolved
resources/qml/RoomDirectory.qml Outdated Show resolved Hide resolved
resources/qml/RoomDirectory.qml Outdated Show resolved Hide resolved
resources/qml/RoomDirectory.qml Outdated Show resolved Hide resolved
resources/qml/RoomDirectory.qml Outdated Show resolved Hide resolved
src/RoomDirectoryModel.h Show resolved Hide resolved
src/RoomDirectoryModel.cpp Outdated Show resolved Hide resolved
src/RoomDirectoryModel.cpp Outdated Show resolved Hide resolved
resources/res.qrc Outdated Show resolved Hide resolved
resources/qml/RoomList.qml Outdated Show resolved Hide resolved
@kamathmanu kamathmanu mentioned this pull request Aug 12, 2021
Closed
LorenDB
LorenDB approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@LorenDB LorenDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

deepbluev7
deepbluev7 requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@deepbluev7 deepbluev7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's getting there, but I have a small more cleanups for you ;-)

@deepbluev7
Copy link
Member

Looks good to me, thank you! And thank you for spending so much time on this and sticking through with it!

@deepbluev7 deepbluev7 merged commit b01496f into Nheko-Reborn:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepbluev7 deepbluev7 deepbluev7 requested changes

@LorenDB LorenDB LorenDB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Room directory
3 participants
@kamathmanu @deepbluev7 @LorenDB