Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup improvements #9

Merged

Conversation

@Ickerday
Copy link
Contributor

commented Jul 7, 2018

I noticed unlisted dependencies were keeping me from successfully compiling the executable, so I gathered them in one place, updated the readme and added a shell script to speed up building on macOS.

I also moved the from multiprocessing import Queue dependency to build_exe_options - the program compiles and works fine on macOS, but someone should check if it works Windows. This would save the headache of an unused import, should someone carelessly remove it (i.e. me 馃槑)

@Nick-Gottschlich

This comment has been minimized.

Copy link
Owner

commented Jul 7, 2018

I'll test out the build on my windows machine.

Edit: builds just fine on windows 馃憤

@Nick-Gottschlich
Copy link
Owner

left a comment

Thanks, this looks good.

@Nick-Gottschlich Nick-Gottschlich merged commit 0a357ae into Nick-Gottschlich:master Jul 7, 2018

@Ickerday Ickerday deleted the Ickerday:feature/setup_improvements branch Jul 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.