Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagPro Analytics 3.0 compatibility with userscripts-disabled mode #13

Merged
merged 2 commits into from Nov 18, 2018

Conversation

Projects
None yet
3 participants
@RondingTagPro
Copy link
Contributor

commented Oct 25, 2018

This enables the possibility for TagPro Analytics to operate in
userscripts-disabled mode.

The file is identical to https://tagpro.eu/collector.js.

Upon initialisation, match join, match start, and match completion, it
exposes game data to userscripts (in particular aimed at the TagPro
Analytics 3.0 userscript) via a simple event system (events are sent by
the report() function). Except for the match completion event, these
events contain no competitively sensitive data whatsoever.

RondingTagPro added some commits Oct 25, 2018

Merge pull request #1 from Nick-Riggs/master
Rotate the tips every 15 seconds
TagPro Analytics 3.0 compatibility with userscripts-disabled mode
This enables the possibility for TagPro Analytics to operate in
userscripts-disabled mode.

The file is identical to https://tagpro.eu/collector.js.

Upon initialisation, match join, match start, and match completion, it
exposes game data to userscripts (in particular aimed at the TagPro
Analytics 3.0 userscript) via a simple event system (events are sent by
the report() function). Except for the match completion event, these
events contain no competitively sensitive data whatsoever.
@RondingTagPro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2018

Note: some minor changes will be necessary later for the single world joiner.

@ylambda

This comment has been minimized.

Copy link
Collaborator

commented Oct 31, 2018

cool - I think our code compressor will strip out the comments/license in this. Is that a problem?

@RondingTagPro

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

I think our code compressor will strip out the comments/license in this. Is that a problem?

That's fine.

@ylambda

This comment has been minimized.

Copy link
Collaborator

commented Nov 2, 2018

cool - i'll put this in later today. I think the leagues will love your work.

@ylambda

This comment has been minimized.

Copy link
Collaborator

commented Nov 18, 2018

Ok I got this working locally now. Will make sure luckyspammer wants this

@ylambda ylambda merged commit e7dc706 into Nick-Riggs:master Nov 18, 2018

@Nick-Riggs

This comment has been minimized.

Copy link
Owner

commented Nov 19, 2018

This has been deployed to the servers.

@RondingTagPro

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

Appears to work as expected in production. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.