Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagPro Analytics 3.0 compatibility with userscripts-disabled mode #13

Merged
merged 2 commits into from Nov 18, 2018

Conversation

@RondingTagPro
Copy link
Contributor

@RondingTagPro RondingTagPro commented Oct 25, 2018

This enables the possibility for TagPro Analytics to operate in
userscripts-disabled mode.

The file is identical to https://tagpro.eu/collector.js.

Upon initialisation, match join, match start, and match completion, it
exposes game data to userscripts (in particular aimed at the TagPro
Analytics 3.0 userscript) via a simple event system (events are sent by
the report() function). Except for the match completion event, these
events contain no competitively sensitive data whatsoever.

Rotate the tips every 15 seconds
This enables the possibility for TagPro Analytics to operate in
userscripts-disabled mode.

The file is identical to https://tagpro.eu/collector.js.

Upon initialisation, match join, match start, and match completion, it
exposes game data to userscripts (in particular aimed at the TagPro
Analytics 3.0 userscript) via a simple event system (events are sent by
the report() function). Except for the match completion event, these
events contain no competitively sensitive data whatsoever.
@RondingTagPro
Copy link
Contributor Author

@RondingTagPro RondingTagPro commented Oct 25, 2018

Note: some minor changes will be necessary later for the single world joiner.

@ylambda
Copy link
Collaborator

@ylambda ylambda commented Oct 31, 2018

cool - I think our code compressor will strip out the comments/license in this. Is that a problem?

@RondingTagPro
Copy link
Contributor Author

@RondingTagPro RondingTagPro commented Nov 1, 2018

I think our code compressor will strip out the comments/license in this. Is that a problem?

That's fine.

@ylambda
Copy link
Collaborator

@ylambda ylambda commented Nov 2, 2018

cool - i'll put this in later today. I think the leagues will love your work.

@ylambda
Copy link
Collaborator

@ylambda ylambda commented Nov 18, 2018

Ok I got this working locally now. Will make sure luckyspammer wants this

@ylambda ylambda merged commit e7dc706 into Nick-Riggs:master Nov 18, 2018
@Nick-Riggs
Copy link
Owner

@Nick-Riggs Nick-Riggs commented Nov 19, 2018

This has been deployed to the servers.

@RondingTagPro
Copy link
Contributor Author

@RondingTagPro RondingTagPro commented Nov 19, 2018

Appears to work as expected in production. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants