Skip to content

Fix "input type=color - Field validation" test. #131

Closed
wants to merge 1 commit into from

5 participants

@int32t
int32t commented Apr 10, 2012

A color type field never be invalid because any invalid values are sanitized to
a valid value "#000000".

Opera and WebKit will pass this test.
https://bugs.webkit.org/show_bug.cgi?id=83533

@tkent-google tkent-google Fix "input type=color - Field validation" test.
A color type field never be invalid because any invalid values are sanitized to
a valid value "#000000".
d62a699
@beverloo

Section of the specification which describes this behavior:
http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#color-state-(type=color)

Will element.field.value reflect the internal change to "#000000"? If so, it's probably good practice to verify whether it's actually being changed to that when invalid values are being set.

@int32t
int32t commented Jun 25, 2012

Will element.field.value reflect the internal change to "#000000"?

Yes. But I don't think we should verify the resultant value because the previous test "Value sanitization" should be responsible for it.

@miketaylr

+1 for @int32t's change. As is, this test doesn't make much sense.

@NielsLeenheer
Owner

Going to remove the validation test completely in the next version (current at alpha.html5test.com)

@int32t
int32t commented Jul 10, 2012

Going to remove the validation test completely in the next version (current at alpha.html5test.com)

Ok, it makes sense.

@int32t int32t closed this Jul 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.