Browse files

x86-32, mm: Rip out x86_32 NUMA remapping code

commit f03574f upstream.

This code was an optimization for 32-bit NUMA systems.

It has probably been the cause of a number of subtle bugs over
the years, although the conditions to excite them would have
been hard to trigger.  Essentially, we remap part of the kernel
linear mapping area, and then sometimes part of that area gets
freed back in to the bootmem allocator.  If those pages get
used by kernel data structures (say mem_map[] or a dentry),
there's no big deal.  But, if anyone ever tried to use the
linear mapping for these pages _and_ cared about their physical
address, bad things happen.

For instance, say you passed __GFP_ZERO to the page allocator
and then happened to get handed one of these pages, it zero the
remapped page, but it would make a pte to the _old_ page.
There are probably a hundred other ways that it could screw
with things.

We don't need to hang on to performance optimizations for
these old boxes any more.  All my 32-bit NUMA systems are long
dead and buried, and I probably had access to more than most

This code is causing real things to break today:

I looked in to actually fixing this, but it requires surgery
to way too much brittle code, as well as stuff like

[ hpa: Cc: this for -stable, since it is a memory corruption issue.
  However, an alternative is to simply mark NUMA as depends BROKEN
  rather than EXPERIMENTAL in the X86_32 subclause... ]

Signed-off-by: H. Peter Anvin <>
[bwh: For 3.2, using the suggested alternative]
Signed-off-by: Ben Hutchings <>
  • Loading branch information...
1 parent 1156e00 commit 6d6e66d90d1e9564d20060ffd03dbf75ed85c7d2 Dave Hansen committed with bwhacks Jan 31, 2013
Showing with 1 addition and 1 deletion.
  1. +1 −1 arch/x86/Kconfig
@@ -1150,7 +1150,7 @@ config DIRECT_GBPAGES
config NUMA
bool "Numa Memory Allocation and Scheduler Support"
depends on SMP
- depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_BIGSMP || X86_SUMMIT && ACPI) && EXPERIMENTAL)
+ depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_BIGSMP || X86_SUMMIT && ACPI) && BROKEN)
default y if (X86_NUMAQ || X86_SUMMIT || X86_BIGSMP)
Enable NUMA (Non Uniform Memory Access) support.

0 comments on commit 6d6e66d

Please sign in to comment.