Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect is undefined on IE11 - Wrong vue-class-component version? #320

Closed
ThomasPoncet opened this Issue Mar 12, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@ThomasPoncet
Copy link

ThomasPoncet commented Mar 12, 2019

The package can't be loaded on IE11 (it uses Reflect that I don't polyfill in my project):

'Reflect' is undefined

It seems that the package uses an old version of vue-class-components (v6.3.0) and this version breaks on IE11.

A fix has been released on the vue-class-components (v6.3.2).

If I manually clone the vue-slider-component GitHub repository, manually build the project and then replace in my project the directory node_modules/vue-slider-component by the directory where I cloned and build the vue-slider-component repository, I don't have the error on IE11 and vue-class-components is in version 6.3.2.

Is it possible to update vue-class-components on the published package? Or is the problem comming from my project?

Thank you for your help

@ThomasPoncet ThomasPoncet added the bug label Mar 12, 2019

@NightCatSama

This comment has been minimized.

Copy link
Owner

NightCatSama commented Mar 13, 2019

Thank you for your feedback, which will be updated later.

@NightCatSama

This comment has been minimized.

Copy link
Owner

NightCatSama commented Mar 13, 2019

I upgraded vue-class-component to 7.0.1 and re-released version 3.0.9.

@ThomasPoncet

This comment has been minimized.

Copy link
Author

ThomasPoncet commented Mar 13, 2019

@NightCatSama Thank your for your quick answer and action. I did try to update the package and it didn't fix the bug.

I did try something else: I did install vue-slider-component with npm in a new and clean directory

npm init
npm install -P vue-slider-component

And the version of vue-class-component in vue-slider-component seems still to be v6.3.0 (I open one of the js file in node_modules/dist, for example node_modulesdist/vue-slider-component.umd.min.js as it is the main, and I search Reflect).

I don't really understand how dependencies of vue-slider-component are packaged with vue-slider-component and then published on npm, but I feel like the wrong version of vue-class-component is sent to npm.

Let me know if I can add additional informations.

@NightCatSama

This comment has been minimized.

Copy link
Owner

NightCatSama commented Mar 13, 2019

@ThomasPoncet Thank you for your help

In fact, the component does not directly use vue-class-component, I need to update is vue-property-decorator.

I released version 3.0.11, please help me test it again.

@ThomasPoncet

This comment has been minimized.

Copy link
Author

ThomasPoncet commented Mar 13, 2019

@NightCatSama Yes, it's fixed on my side! 🎉

Thank you very much for your help! 🙏

Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.