New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wear sync if timestamp difference is older than zero. #610

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@nielsvanvelzen
Contributor

nielsvanvelzen commented Oct 3, 2018

Every time when entering data using my smartwatch (Ticwatch E) the sync would fail because the timestamp difference (since variable) was around -900.

This PR fixes the issue by allowing timestamps up to five seconds older than the current time.

@jamorham

This comment has been minimized.

Contributor

jamorham commented Oct 5, 2018

Overall this looks good. As far as I can work out, future treatments shouldn't cause a problem here especially by only a few seconds.

@nielsvanvelzen

This comment has been minimized.

Contributor

nielsvanvelzen commented Oct 6, 2018

I did not know if it would cause issues so therefore I restricted it to only 5 seconds.

@jamorham jamorham merged commit 70c68fe into NightscoutFoundation:master Oct 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment