Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more movie quotes #3

Open
NikhilNamal17 opened this issue Oct 5, 2019 · 41 comments

Comments

@NikhilNamal17
Copy link
Owner

commented Oct 5, 2019

Do you know any popular movie quotes?
Add your quote to data.json inside the data/ folder and raise the PR.

{  
      "quote": "Your new Quote",
      "movie": "Movie Name",
      "type": "movie/anime/tv",
      "year": 2012
}

Note:

Please avoid the repetition of quotes.
Do not make any changes in other files.
Add me(@NikhilNamal17 ) as reviewer.
Thanks!

@robflop

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

Hello, I have a question. Does "first-timers-only" (and its hovertext "Send your first PR") refer to one's first Hacktoberfest PR or how is this to be understood?

@NikhilNamal17

This comment has been minimized.

Copy link
Owner Author

commented Oct 5, 2019

The label refers to their first open-source contribution. Basically this issue is targeted for beginners but there are no restrictions.

@robflop

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

Okay, thank you. If multiple PRs can be accepted for this issue then I would like to submit one. If not I will leave it for someone that is a beginner.

@jdim

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

Hi, can I help? It's funny))

@NikhilNamal17

This comment has been minimized.

Copy link
Owner Author

commented Oct 5, 2019

@robflop Yes, you can send multiple PR.

@DylPickle11

This comment has been minimized.

Copy link

commented Oct 5, 2019

Ok I will also do that! YAY!

@bigton54

This comment has been minimized.

Copy link

commented Oct 6, 2019

I would like to add some!

@k1dnyy

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

I would love to add a few!

@MSurfer20

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

Can I contribute?

@rvk7895

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

I would like to contribute to this.TIA

@Harshwp

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

I would love to contribute

@NikhilNamal17

This comment has been minimized.

Copy link
Owner Author

commented Oct 6, 2019

@MSurfer20 sure.

@jaywantpatel

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

Can I contribute to this ?

@NikhilNamal17

This comment has been minimized.

Copy link
Owner Author

commented Oct 6, 2019

@davidlfox

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

How can I test this locally before submitting PR?

@darpanjbora

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2019

Also, I cleared all duplicates quotes too. Now it's around 1k lines. It would be great if someone can review and add missing attributes,

Hi @NikhilNamal17
I have created a new issue for the same. #210
I have added the missing attribute "type" to all the objects. Submitted PR #211
Kindly review and accept the PR.
Also adding the script that I had used for reference.

const data = require("../data/data.json");
const fs = require('fs');
var new_data = data.map( datum => {
var newField = Object.assign({}, datum);
newField.type = "movie";
return newField;
})
fs.writeFileSync('file.json', JSON.stringify(new_data));

@prosaicpudding

This comment has been minimized.

Copy link

commented Oct 12, 2019

I've noticed a few quotes that are misattributed. Would correcting that fall under this issue as well?

@tylercaceres

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2019

I would like to contribute. :)

mergify bot added a commit that referenced this issue Oct 14, 2019
PR for #3: added new quote from the movie 'The Drop'
@iepoch

This comment has been minimized.

Copy link

commented Oct 14, 2019

I would like to work on this as well! :)

@Kudzanayi-Dzvairo

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2019

please review #234

@Volence

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2019

Just did my first pull request ( #242 ) on github! I'm used to gitlab so please let me know if I did anything incorrectly. I tagged you in that but I'm not sure if that made you the reviewer. Thanks for this project!

@mai-am

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2019

Added a few from Once Upon a Time in Hollywood. Couldn't figure out how to make you the reviewer @NikhilNamal17. :)

wilk pushed a commit to wilk/popular-movie-quotes that referenced this issue Oct 15, 2019
@wilk wilk referenced this issue Oct 15, 2019
mergify bot added a commit that referenced this issue Oct 15, 2019
#3 add two quotes
wilk pushed a commit to wilk/popular-movie-quotes that referenced this issue Oct 15, 2019
@wilk wilk referenced this issue Oct 15, 2019
mergify bot added a commit that referenced this issue Oct 15, 2019
#3 add two quotes
pndyjack added a commit to pndyjack/popular-movie-quotes that referenced this issue Oct 15, 2019
Refers to NikhilNamal17#3
pndyjack added a commit to pndyjack/popular-movie-quotes that referenced this issue Oct 15, 2019
Refers to NikhilNamal17#3
pndyjack added a commit to pndyjack/popular-movie-quotes that referenced this issue Oct 15, 2019
Refers to NikhilNamal17#3
pndyjack added a commit to pndyjack/popular-movie-quotes that referenced this issue Oct 15, 2019
Refers to NikhilNamal17#3
pndyjack added a commit to pndyjack/popular-movie-quotes that referenced this issue Oct 15, 2019
Refers to NikhilNamal17#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.