Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange issue with latest bevy main #31

Closed
VisualEhrmanntraut opened this issue Nov 4, 2021 · 10 comments
Closed

Strange issue with latest bevy main #31

VisualEhrmanntraut opened this issue Nov 4, 2021 · 10 comments

Comments

@VisualEhrmanntraut
Copy link

error[E0277]: the trait bound `AudioSource: TypeUuid` is not satisfied
  --> src/states/mod.rs:8:22
   |
8  |     pub loop_handle: Handle<AudioSource>,
   |                      ^^^^^^^^^^^^^^^^^^^ the trait `TypeUuid` is not implemented for `AudioSource`
   |
   = note: required because of the requirements on the impl of `Asset` for `AudioSource`
note: required by a bound in `bevy::prelude::Handle`
  --> /Users/visual/.cargo/git/checkouts/bevy-f7ffde730c324c74/91c3b21/crates/bevy_asset/src/handle.rs:65:8
   |
65 |     T: Asset,
   |        ^^^^^ required by this bound in `bevy::prelude::Handle`

For more information about this error, try `rustc --explain E0277`.
@NiklasEi
Copy link
Owner

NiklasEi commented Nov 4, 2021

To be sure: you are using the bevy_main branch and Bevy's bevy_audio and mp3 features are not enabled (both are default features)?

@VisualEhrmanntraut
Copy link
Author

image

@NiklasEi
Copy link
Owner

NiklasEi commented Nov 4, 2021

Could you try pinning Bevy to the same commit bevy_kira_audio uses?
The bevy_main branch uses bevy = { git = "https://github.com/bevyengine/bevy", rev = "6a8a8c9d21f32e0e46623db9438813b009f9e014" }.

@VisualEhrmanntraut
Copy link
Author

That works, but, that restricts me to use that specific commit

@NiklasEi
Copy link
Owner

NiklasEi commented Nov 4, 2021

If there are no further breaking changes since that commit, you should be able to patch the bevy dependency from the official repository to your own fork in your Cargo file. Then bevy_kira_audio will use the latest commit, too.

@VisualEhrmanntraut
Copy link
Author

This issue might be resolved if you update the bevy revision
image
image

@VisualEhrmanntraut
Copy link
Author

VisualEhrmanntraut commented Nov 4, 2021

Also, I recommend reading https://bevy-cheatbook.github.io/setup/bevy-git.html

@VisualEhrmanntraut
Copy link
Author

Yes, if you update to latest bevy main the issue is fixed.
image
@NiklasEi

@NiklasEi
Copy link
Owner

NiklasEi commented Nov 4, 2021

I choose on purpose to pin the Bevy dependency because I want the branch to always work. See #13 for the last time this came up.

An alternative I have been considering is to depend on the main branch without pinning a working revision and have some workflow regularly check if all tests are still green. But for now I would like to keep pinning working revisions.

@NiklasEi
Copy link
Owner

NiklasEi commented Dec 4, 2021

I will close this for now, because the used Bevy commit can be patched in the user's Cargo.toml file. You can also patch the Bevy dependency to use the latest Bevy main commit, which means you don't have to update the reference all the time.

I also updated the Bevy commit on the bevy_main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants