Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: proofread market terminology and fronted pages #70

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

alexandra-mara
Copy link

@alexandra-mara alexandra-mara commented Jul 7, 2023

Part of #66, review and proofreading of the Proof Market documentation:

Includes:

  • proofread for both pages, fixed inaccuracies and added the needed cross-links
  • updates for terminology on the Frontend page according to current state of the web interface on proof.market
  • updates for description and parameters of buy and sell orders
  • bid/ask -> request/proposal rename – part of Update PMT readme and PM docs to support the terminology change #63
  • screenshots of the new Proof Market's interface

TODO:

  • rename Frontend to Web interface, set up redirects — will be done in a separate task

@alexandra-mara alexandra-mara marked this pull request as ready for review July 7, 2023 14:11
@knazarov
Copy link
Contributor

I would kindly suggest to put a more detailed PR description. It would at help with understanding of the scope of changes. And this, in order, would increase the chances that interested parties would leave a review.

@alexandra-mara alexandra-mara force-pushed the 66-proofread-documentation branch 2 times, most recently from 3833131 to eaf045a Compare July 10, 2023 14:03
gitbook-docs/market/front-end.md Outdated Show resolved Hide resolved
gitbook-docs/market/front-end.md Outdated Show resolved Hide resolved
gitbook-docs/market/front-end.md Outdated Show resolved Hide resolved
gitbook-docs/market/front-end.md Outdated Show resolved Hide resolved
gitbook-docs/market/front-end.md Outdated Show resolved Hide resolved
gitbook-docs/market/overview.md Outdated Show resolved Hide resolved
gitbook-docs/market/overview.md Outdated Show resolved Hide resolved
gitbook-docs/market/overview.md Outdated Show resolved Hide resolved
gitbook-docs/market/overview.md Outdated Show resolved Hide resolved
gitbook-docs/market/overview.md Outdated Show resolved Hide resolved
@alexandra-mara alexandra-mara marked this pull request as draft July 12, 2023 17:12
@alexandra-mara alexandra-mara marked this pull request as ready for review July 13, 2023 12:54
@alexandra-mara alexandra-mara changed the title 66 docs: proofread market terminology and fronted pages docs: proofread market terminology and fronted pages Jul 13, 2023
@NickVolynkin NickVolynkin removed the request for review from hgedia July 14, 2023 08:53
@NickVolynkin NickVolynkin dismissed SK0M0R0H’s stale review July 14, 2023 11:09

requested changes were made

@alexandra-mara alexandra-mara force-pushed the 66-proofread-documentation branch 3 times, most recently from 631a3f6 to 684f7f5 Compare July 14, 2023 12:23
* Proofread for both pages, fixed inaccuracies and added the needed cross-links - part of #66
* Updates for terminology on the Frontend page according to current state of the web interface on proof.market
* Updates for description and parameters of buy and sell orders
* Bid/ask -> request/proposal rename - part of #63
* Screenshots of the new Proof Market's interface
@NickVolynkin NickVolynkin merged commit a806224 into 00-gitbook-docs Jul 14, 2023
@NickVolynkin NickVolynkin deleted the 66-proofread-documentation branch July 14, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants