Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tinkers Construct Quest Line and Loot Tables #3636

Merged
merged 6 commits into from Nov 19, 2021

Conversation

mcilhargey
Copy link
Contributor

@mcilhargey mcilhargey commented Nov 2, 2021

Add a Tinkers quest line to educate/reward building in the tinkers line. This quest line has it's own loot tables based on items in the mod itself.

@NielsPilgaard
Copy link
Collaborator

NielsPilgaard commented Nov 6, 2021

Looks good from what I've read so far 👍
I would however like the slime island quests to not be checkbox based, perhaps they could be merged to be one per dimension, and just require the saplings and such? I didn't realize some child quests were advancement-based, it's good as-is.

@theboo
Copy link
Collaborator

theboo commented Nov 11, 2021

got home late from work today, ill look through these tomorrow

Copy link
Collaborator

@theboo theboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed a few typo/grammar changes directly, hope that's okay... Below is some stuff i found/wasnt sure about to look in to :).

no description in "puny smelting" task, as i dont know tinkers 1.16 well at all, unsure if this is intended
image

checkmark quest for tinkers upgrade, is there an advancement for your first applied upgrade that might be able to be used instead?
image
same question here:
image

If one of the books has info on what the various frames' effects are, you might mention that here?
image

@KnightMiner
Copy link

KnightMiner commented Nov 12, 2021

checkmark quest for tinkers upgrade, is there an advancement for your first applied upgrade that might be able to be used instead?

You an easily create an advancement that checks for a tinker tool having one of a list of modifiers. The syntax is rather verbose, but look into the TiC "ability master" advancement or the "upgrade slots" advancement. If you can read java, see also the deserializer for that predicate.

Note that in code the term upgrades sometimes refers to either upgrades or abilities, so your best bet is a making a list of upgrades and abilities to check against (can easily be done in a "modifier match")

@MuteTiefling
Copy link
Contributor

If they're advancements, we can actually just watch for those.

@KnightMiner
Copy link

The advancements don't do exactly what you want the ones I mentioned are for applying all modifiers from a particular set, not applying just 1

Copy link
Collaborator

@theboo theboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!!

@NielsPilgaard NielsPilgaard merged commit 92e1aca into EnigmaticaModpacks:develop Nov 19, 2021
@NielsPilgaard
Copy link
Collaborator

Woohoo \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants