New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tinkers Construct Quest Line and Loot Tables #3636
Add Tinkers Construct Quest Line and Loot Tables #3636
Conversation
a3b0734
to
b0e1148
Compare
Looks good from what I've read so far 👍 |
got home late from work today, ill look through these tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I committed a few typo/grammar changes directly, hope that's okay... Below is some stuff i found/wasnt sure about to look in to :).
no description in "puny smelting" task, as i dont know tinkers 1.16 well at all, unsure if this is intended
checkmark quest for tinkers upgrade, is there an advancement for your first applied upgrade that might be able to be used instead?
same question here:
If one of the books has info on what the various frames' effects are, you might mention that here?
You an easily create an advancement that checks for a tinker tool having one of a list of modifiers. The syntax is rather verbose, but look into the TiC "ability master" advancement or the "upgrade slots" advancement. If you can read java, see also the deserializer for that predicate. Note that in code the term |
If they're advancements, we can actually just watch for those. |
The advancements don't do exactly what you want the ones I mentioned are for applying all modifiers from a particular set, not applying just 1 |
e530057
to
3e978f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!!
Woohoo \o/ |
Add a Tinkers quest line to educate/reward building in the tinkers line. This quest line has it's own loot tables based on items in the mod itself.