Preflight unsupported VS Code runtimes before PDF export#22
Merged
MelbourneDeveloper merged 3 commits intoMay 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Preflight unsupported VS Code runtimes before markdown PDF export, add a regression test for the early-fail path, and ratchet
packages/webcoverage thresholds after the passing CI run.Details
Closes #20.
What was changed:
exportPdfregression test that asserts unsupported runtimes fail before markdown is read, HTML is composed, or a PDF is written.isPrintToPdfRuntimeSupporteddependency in the VS Code PDF export path and used it to fail fast with the existing desktop-VS-Code error message.vscode.env.uiKind === vscode.UIKind.Desktop.UIKindandenv.uiKindso the runtime-capability path is testable.coverage-thresholds.jsonforpackages/webaftermake cipassed and the repo’s ratchet step raised those thresholds.What was added:
What was changed/deleted:
How Do The Automated Tests Prove It Works?
make cipassed end-to-end.packages/vscode/test/export-pdf.test.tsnow includespreflights unsupported runtimes before reading or composing the markdown, which proves the command stops beforereadFile,createWebviewPanel, andwriteFileon unsupported runtimes.packages/vscodesuite passed, includingtest/export-pdf.test.ts,test/export-pdf-physical.test.ts, andtest/extension.test.ts.make ci, and the repo ratchetedpackages/webcoverage thresholds from the measured passing run.