Bring back the emr_credentials call #1

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@orenhe

orenhe commented Mar 10, 2013

No description provided.

@Nimster

This comment has been minimized.

Show comment Hide comment
@Nimster

Nimster Mar 10, 2013

I want to change emr_credentials to not add them by default, otherwise it fails if you haven't specified them anywhere (right now the current code works, but if I take your pull request, I will always insert either --credentials or --access-id and --private-key to the command line). So can you also patch emr_credentials function to return nothing if access-id and/or private-key don't exist? Then I will accept this pull.

I want to change emr_credentials to not add them by default, otherwise it fails if you haven't specified them anywhere (right now the current code works, but if I take your pull request, I will always insert either --credentials or --access-id and --private-key to the command line). So can you also patch emr_credentials function to return nothing if access-id and/or private-key don't exist? Then I will accept this pull.

This comment has been minimized.

Show comment Hide comment
@orenhe

orenhe Mar 10, 2013

Owner

In my use case I always pass --credentials so I didn't see any problem. So, good point. ok.

Owner

orenhe replied Mar 10, 2013

In my use case I always pass --credentials so I didn't see any problem. So, good point. ok.

@Nimster Nimster closed this May 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment