Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `hasNotch` property #38

merged 3 commits into from Jun 15, 2019


None yet
3 participants
Copy link

commented Jun 13, 2019

It can be useful to know if the current device has a notch or not. I felt like this belonged in an open source project.

Daniel added some commits Jun 13, 2019


This comment has been minimized.

Copy link

commented Jun 13, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #38     +/-   ##
+ Coverage   93.34%   93.44%   +0.1%     
  Files          12       12             
  Lines         886      900     +14     
+ Hits          827      841     +14     
  Misses         59       59
Impacted Files Coverage Δ
Tests/UIDeviceExtensionsTests.swift 100% <ø> (ø) ⬆️
Tests/DeviceModelTests.swift 100% <100%> (ø) ⬆️
Sources/DeviceModel.swift 99.17% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29631f5...692b412. Read the comment docs.


This comment has been minimized.

Copy link

commented Jun 15, 2019

@danramteke Good deal! I like this! I will pump out a release with this soon!

@Nirma Nirma merged commit 68c146b into Nirma:master Jun 15, 2019

3 checks passed

codecov/patch 100% of diff hit (target 93.34%)
codecov/project 93.44% (+0.1%) compared to 29631f5
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.