Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search button and link it to function #5

Merged
merged 3 commits into from Oct 6, 2019

Conversation

alexresiga
Copy link
Contributor

#4

@NitinNair89
Copy link
Owner

Thanks! Can you setup a GitHub page pointing to your fork repo's master branch so that I can view the UI with your code changes?

@alexresiga
Copy link
Contributor Author

Copy link
Owner

@NitinNair89 NitinNair89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://alexresiga.github.io/TheHungryRecipes/index.html

The interface is broken. Please make the below changes:

  • "Search Recipe" should be the button text and position it below the "Random Recipe" button
  • Add the chef hat icon to the search recipe button
  • Do not change the grid column size, keep it as-is

FireShot Capture 004 - The Hungry Recipes - alexresiga github io

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Owner

@NitinNair89 NitinNair89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the live site on the link you previously shared. The alignment seems a little off. Let's do it this way:

  • Create a row inside the eight columns div similar to the structure made for the input field
  • Keep the chef hat icon for the random recipe button

@NitinNair89 NitinNair89 added this to In progress in TheHungryRecipes via automation Oct 6, 2019
@alexresiga
Copy link
Contributor Author

I checked the live site on the link you previously shared. The alignment seems a little off. Let's do it this way:

the alignment is a bit off because the buttons don't have a fixed width they expand with the text inside them

  • Create a row inside the eight columns div similar to the structure made for the input field

i don't understand what you mean by this

  • Keep the chef hat icon for the random recipe button

ok

@NitinNair89
Copy link
Owner

NitinNair89 commented Oct 6, 2019

i don't understand what you mean by this

Currently, the h4 is floating and occupies full width of its container. We can create a row class div with the same structure as for input field

Current code:
<h4>Confused what to cook? <br/><small>Search a recipe or try a random recipe!</small></h4>

Suggestion:

<div class="row">
  <div class="eight columns">
    <h4>Confused what to cook? <br/><small>Search a recipe or try a random recipe!</small></h4>
  </div>
  <div class="four columns">
      Random Recipe button
  </div>
</div>

Can you give this a try and see if it solves alignment issues? 🙂

@NitinNair89
Copy link
Owner

Have you tested everything?

@alexresiga
Copy link
Contributor Author

yes, you can see oh the gh pages link

@NitinNair89
Copy link
Owner

yes, you can see oh the gh pages link

Looks fine. There's a bug, I will open a separate issue and assign it to you. Is that fine?

@NitinNair89 NitinNair89 merged commit dc802d3 into NitinNair89:master Oct 6, 2019
TheHungryRecipes automation moved this from In progress to Done Oct 6, 2019
@NitinNair89
Copy link
Owner

Closes #4

@alexresiga
Copy link
Contributor Author

Looks fine. There's a bug, I will open a separate issue and assign it to you. Is that fine?

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants