Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content assist includes a lot of irrelevant alternatives #5

Closed
xkr47 opened this issue Mar 25, 2012 · 4 comments
Closed

Content assist includes a lot of irrelevant alternatives #5

xkr47 opened this issue Mar 25, 2012 · 4 comments

Comments

@xkr47
Copy link
Member

xkr47 commented Mar 25, 2012

Need to rewrite the matching logic a little bit

@efonsell
Copy link
Member

Some examples of irrelevant matches, please?

@xkr47
Copy link
Member Author

xkr47 commented Mar 30, 2012

If you have a keyword definition with an inline argument in the middle, it will currently always show up in the results. For example:

Enter ${username} into form and click the register button

Currently the keyword completion code picks keywords to suggest using a wildcard matcher that treats inline variables as wildcards. This is done in order to make sure the following keyword call matches the above keyword declaration:

Example testcase
  Enter kalle into form and click the register button

It can also be the other way around, where the keyword call uses a variable, while the keyword definition does not. Or even a combination of the two.

The extra matches occur because I was experimenting with substring matches and the code is not finished yet. In a typical scenario the user might not remember the exact keyword name and enter for example just "register" hoping to get a list of keywords containing "register". So my quick hack was to put some dummy variables around the search string to get a substring search. But it didn't work out so well.

@efonsell
Copy link
Member

Treating inline variable as wildcards is not commented out. When it's uncommented it should be fixed to work, too.

@xkr47
Copy link
Member Author

xkr47 commented Feb 27, 2013

Included in release 1.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants