From 36778657a66f45e12d77ba8c9d8abdf0d6b5eada Mon Sep 17 00:00:00 2001 From: Edvard Fonsell Date: Tue, 2 Dec 2014 10:10:03 +0200 Subject: [PATCH] add test --- .../definition/AbstractWorkflowDefinition.java | 2 +- .../workflow/definition/WorkflowDefinitionTest.java | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/nflow-engine/src/main/java/com/nitorcreations/nflow/engine/workflow/definition/AbstractWorkflowDefinition.java b/nflow-engine/src/main/java/com/nitorcreations/nflow/engine/workflow/definition/AbstractWorkflowDefinition.java index 6f1ba4aa6..108ab5f88 100644 --- a/nflow-engine/src/main/java/com/nitorcreations/nflow/engine/workflow/definition/AbstractWorkflowDefinition.java +++ b/nflow-engine/src/main/java/com/nitorcreations/nflow/engine/workflow/definition/AbstractWorkflowDefinition.java @@ -43,7 +43,7 @@ protected AbstractWorkflowDefinition(String type, S initialState, S errorState) protected AbstractWorkflowDefinition(String type, S initialState, S errorState, WorkflowSettings settings) { Assert.notNull(initialState, "initialState must not be null"); - Assert.isTrue(initialState.getType() == WorkflowStateType.start, "initial state must be a start state"); + Assert.isTrue(initialState.getType() == WorkflowStateType.start, "initialState must be a start state"); Assert.notNull(errorState, "errorState must not be null"); Assert.isTrue(isStateFinal(errorState), "errorState must be a final state"); this.type = type; diff --git a/nflow-engine/src/test/java/com/nitorcreations/nflow/engine/workflow/definition/WorkflowDefinitionTest.java b/nflow-engine/src/test/java/com/nitorcreations/nflow/engine/workflow/definition/WorkflowDefinitionTest.java index 75ba64742..deb39aa5c 100644 --- a/nflow-engine/src/test/java/com/nitorcreations/nflow/engine/workflow/definition/WorkflowDefinitionTest.java +++ b/nflow-engine/src/test/java/com/nitorcreations/nflow/engine/workflow/definition/WorkflowDefinitionTest.java @@ -36,6 +36,14 @@ public void initialStateIsRequired() { }; } + @Test + public void initialStateMustBeStartState() { + thrown.expect(IllegalArgumentException.class); + thrown.expectMessage("initialState must be a start state"); + new WorkflowDefinition("nonStartInitialState", TestState.done, TestState.error) { + }; + } + @Test public void errorStateIsRequired() { thrown.expect(IllegalArgumentException.class); @@ -45,7 +53,7 @@ public void errorStateIsRequired() { } @Test - public void errorStateMustBeFinal() { + public void errorStateMustBeFinalState() { thrown.expect(IllegalArgumentException.class); thrown.expectMessage("errorState must be a final state"); new WorkflowDefinition("nonFinalErrorState", TestState.start1, TestState.start1) {