From e250446501d8289f57c1c2c547a456e178fbd3bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juha=20Syrj=C3=A4l=C3=A4?= Date: Mon, 7 Oct 2019 21:25:59 +0300 Subject: [PATCH 1/2] Improve error logging in WorkflowStateProcessor --- .../engine/internal/executor/WorkflowStateProcessor.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/nflow-engine/src/main/java/io/nflow/engine/internal/executor/WorkflowStateProcessor.java b/nflow-engine/src/main/java/io/nflow/engine/internal/executor/WorkflowStateProcessor.java index 0d2a7b5fb..3646ae37d 100644 --- a/nflow-engine/src/main/java/io/nflow/engine/internal/executor/WorkflowStateProcessor.java +++ b/nflow-engine/src/main/java/io/nflow/engine/internal/executor/WorkflowStateProcessor.java @@ -8,6 +8,7 @@ import static io.nflow.engine.workflow.instance.WorkflowInstance.WorkflowInstanceStatus.inProgress; import static io.nflow.engine.workflow.instance.WorkflowInstanceAction.WorkflowActionType.stateExecution; import static io.nflow.engine.workflow.instance.WorkflowInstanceAction.WorkflowActionType.stateExecutionFailed; +import static java.lang.String.format; import static java.lang.Thread.currentThread; import static java.util.Arrays.asList; import static java.util.Collections.emptyList; @@ -228,11 +229,12 @@ private WorkflowInstance saveWorkflowInstanceState(StateExecutionImpl execution, try { return persistWorkflowInstanceState(execution, instance.stateVariables, actionBuilder, instanceBuilder); } catch (Exception ex) { - logger.error("Failed to save workflow instance new state, retrying after {} seconds", stateSaveRetryDelay, ex); + logger.error("Failed to save workflow instance {} new state, retrying after {} seconds", + instance.id, stateSaveRetryDelay, ex); sleepIgnoreInterrupted(stateSaveRetryDelay); } } while (internalRetryEnabled); - throw new IllegalStateException("Failed to save workflow instance new state"); + throw new IllegalStateException(format("Failed to save workflow instance %s new state", instance.id)); } /** From d5ce523442f554b75eef5c59a8e6b09655bbf391 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juha=20Syrj=C3=A4l=C3=A4?= Date: Mon, 7 Oct 2019 21:36:58 +0300 Subject: [PATCH 2/2] Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0b8462827..ee24d3e50 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,6 +44,7 @@ - Gradle 5.5.1 - New REST-API endpoint to wake up workflow instance sleeping in specified states PUT /nflow/api/v1/workflow-instance/5/wakeup +- Improve error logging in WorkflowStateProcessor ## 5.7.0 (2019-06-06)