New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit_unless_managed should be fixed #148

Closed
tkdchen opened this Issue Feb 18, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@tkdchen
Member

tkdchen commented Feb 18, 2017

commit_unless_managed is not available in Django 1.8 and later. It should be replaced with correct equivalent call in Django 1.8.

@tkdchen tkdchen added the bug label Feb 18, 2017

@tkdchen tkdchen added this to the 4.0 milestone Feb 18, 2017

@tkdchen

This comment has been minimized.

Show comment
Hide comment
@tkdchen

tkdchen Feb 18, 2017

Member

Part of #110

Member

tkdchen commented Feb 18, 2017

Part of #110

@tkdchen tkdchen added the high label Feb 22, 2017

@tkdchen tkdchen self-assigned this Feb 26, 2017

atodorov added a commit to MrSenko/Nitrate that referenced this issue Feb 28, 2017

Refactor TP_CLEAR_ENV_GROUP and TP_ADD_ENV_GROUP SQLs into ORM.
also the test added in the previous commit was generating an error
which is now fixed (related to #148). The error was:

'module' object has no attribute 'commit_unless_managed'

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Feb 28, 2017

Refactor TC_REMOVE_CC SQL into ORM. Related to #148
by updating xmlrpc.testcase.notification_remove_cc() method. I've
made this method very similar to notification_add_cc() and
notification_get_cc() methods. Also added a test!

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>
@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Feb 28, 2017

Contributor

After #159 is merged I can look into this since I already have some idea about this area in the code and already made progress adding some tests.

Contributor

atodorov commented Feb 28, 2017

After #159 is merged I can look into this since I already have some idea about this area in the code and already made progress adding some tests.

@tkdchen

This comment has been minimized.

Show comment
Hide comment
@tkdchen

tkdchen Mar 1, 2017

Member

I have already started and part of them have been fixed. I can fix others except those in xmlrpc app you have done in #159.

Member

tkdchen commented Mar 1, 2017

I have already started and part of them have been fixed. I can fix others except those in xmlrpc app you have done in #159.

tkdchen added a commit to tkdchen/Nitrate that referenced this issue Mar 1, 2017

Fix deprecated commit_unless_managed
commit_unless_managed is deprecated and unavailable in django 1.8. This
patch replaces commit_unless_managed with transaction.atomic in
testcases and testruns app.

Related to #148

Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 1, 2017

Refactor TP_CLEAR_ENV_GROUP and TP_ADD_ENV_GROUP SQLs into ORM.
also the test added in the previous commit was generating an error
which is now fixed (related to #148). The error was:

'module' object has no attribute 'commit_unless_managed'

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 1, 2017

Refactor TC_REMOVE_CC SQL into ORM. Related to #148
by updating xmlrpc.testcase.notification_remove_cc() method. I've
made this method very similar to notification_add_cc() and
notification_get_cc() methods. Also added a test!

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 1, 2017

Refactor TC_REMOVE_CC SQL into ORM. Related to #148
by updating xmlrpc.testcase.notification_remove_cc() method. I've
made this method very similar to notification_add_cc() and
notification_get_cc() methods. Also added a test!

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 1, 2017

Refactor TP_CLEAR_ENV_GROUP and TP_ADD_ENV_GROUP SQLs into ORM.
also the test added in the previous commit was generating an error
which is now fixed (related to #148). The error was:

'module' object has no attribute 'commit_unless_managed'

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 1, 2017

Refactor TC_REMOVE_CC SQL into ORM. Related to #148
by updating xmlrpc.testcase.notification_remove_cc() method. I've
made this method very similar to notification_add_cc() and
notification_get_cc() methods. Also added a test!

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 2, 2017

Refactor TP_CLEAR_ENV_GROUP and TP_ADD_ENV_GROUP SQLs into ORM.
also the test added in the previous commit was generating an error
which is now fixed (related to #148). The error was:

'module' object has no attribute 'commit_unless_managed'

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

tkdchen added a commit that referenced this issue Mar 2, 2017

Refactor TP_CLEAR_ENV_GROUP and TP_ADD_ENV_GROUP SQLs into ORM.
also the test added in the previous commit was generating an error
which is now fixed (related to #148). The error was:

'module' object has no attribute 'commit_unless_managed'

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 8, 2017

Add tests and refactor SQL for XML-RPC TestCase.unlink_plan
also removes the use of commit_unless_managed(). Related to #148

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 8, 2017

Add test and refactor SQL for XML-RPC testcase.link_plan()
this commit uses bulk inserts for performance reasons but does
add one extra query to make sure we're not inserting duplicate
records into the 'test_case_plans' table!

This makes the new code more portable between database engines and
also removes the use of commit_unless_managed().

Fix #148

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 9, 2017

Add tests and refactor SQL for XML-RPC TestCase.unlink_plan
also removes the use of commit_unless_managed(). Related to #148

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 9, 2017

Add test and refactor SQL for XML-RPC testcase.link_plan()
this commit uses bulk inserts for performance reasons but does
add one extra query to make sure we're not inserting duplicate
records into the 'test_case_plans' table!

This makes the new code more portable between database engines and
also removes the use of commit_unless_managed().

Fix #148

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

atodorov added a commit to MrSenko/Nitrate that referenced this issue Mar 12, 2017

Add test and refactor SQL for XML-RPC testcase.link_plan()
this commit uses bulk inserts for performance reasons but does
add one extra query to make sure we're not inserting duplicate
records into the 'test_case_plans' table!

This makes the new code more portable between database engines and
also removes the use of commit_unless_managed().

Fix #148

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

tkdchen added a commit that referenced this issue Mar 13, 2017

Add tests and refactor SQL for XML-RPC TestCase.unlink_plan
also removes the use of commit_unless_managed(). Related to #148

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

@tkdchen tkdchen closed this in 980b07b Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment