Use version from module, not txt file #145

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
2 participants
@atodorov
Contributor

atodorov commented Feb 7, 2017

this is cleaner since we don't have to read .txt files and don't
modify the source before building a package.

This makes it possible to show the actual version in Nitrate's webUI
footer by exporting the version as a setting.

The setting can be overriden if desired, for example with
commands.getstatusoutput('rpm -q nitrate')[1]

tcms/__init__.py
@@ -1 +1,2 @@
# -*- coding: utf-8 -*-
+VERSION = '3.8.18'

This comment has been minimized.

@tkdchen

tkdchen Feb 7, 2017

Member

__version__ instead of VERSION

@tkdchen

tkdchen Feb 7, 2017

Member

__version__ instead of VERSION

This comment has been minimized.

@atodorov

atodorov Feb 8, 2017

Contributor

updated

@atodorov

atodorov Feb 8, 2017

Contributor

updated

@tkdchen

This comment has been minimized.

Show comment
Hide comment
@tkdchen

tkdchen Feb 20, 2017

Member

👍 This can be merged after removing VERSION.txt as well and rebase.

Member

tkdchen commented Feb 20, 2017

👍 This can be merged after removing VERSION.txt as well and rebase.

Use version from module, not txt file
this is cleaner since we don't have to read .txt files and don't
modify the source before building a package.

This makes it possible to show the actual version in Nitrate's webUI
footer by exporting the version as a setting.

The setting can be overriden if desired, for example with
commands.getstatusoutput('rpm -q nitrate')[1]

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>

@tkdchen tkdchen merged commit 341ccfa into Nitrate:develop Feb 22, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment