Update tests and fix Travis CI core dump #168

Merged
merged 2 commits into from Mar 9, 2017

Conversation

Projects
None yet
3 participants
@atodorov
Contributor

atodorov commented Mar 5, 2017

This is a fix for #161 which removes tearDownClass and replaces setUpClass with setUpTestData which appears to be the recommended Django way since 1.8. It also magically fixes the core dumps in Travis CI.

The second commit instructs coverage report to omit test files in the report and reveals we have 40% actual code coverage :(

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 5, 2017

Coverage Status

Changes Unknown when pulling 55e49af on MrSenko:fix_travisci_core_dump into ** on Nitrate:develop**.

Coverage Status

Changes Unknown when pulling 55e49af on MrSenko:fix_travisci_core_dump into ** on Nitrate:develop**.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 8, 2017

Coverage Status

Changes Unknown when pulling 3030b01 on MrSenko:fix_travisci_core_dump into ** on Nitrate:develop**.

Coverage Status

Changes Unknown when pulling 3030b01 on MrSenko:fix_travisci_core_dump into ** on Nitrate:develop**.

@tkdchen

This comment has been minimized.

Show comment
Hide comment
@tkdchen

tkdchen Mar 9, 2017

Member

👍 Please sign your commits.

Member

tkdchen commented Mar 9, 2017

👍 Please sign your commits.

atodorov added some commits Mar 5, 2017

Convert setUpClass to setUpTestData and drop tearDownClass()
for all test cases which use the database. This speeds up things
a bit and is more compatible with how Django is supposed to handle
tests that need objects from the database.

Fix #161

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>
Exclude test files from coverage report
Signed-off-by: Mr. Senko <atodorov@mrsenko.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 9, 2017

Coverage Status

Changes Unknown when pulling 67a2b83 on MrSenko:fix_travisci_core_dump into ** on Nitrate:develop**.

Coverage Status

Changes Unknown when pulling 67a2b83 on MrSenko:fix_travisci_core_dump into ** on Nitrate:develop**.

@tkdchen tkdchen merged commit ae3745a into Nitrate:develop Mar 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tkdchen tkdchen added this to the 4.0 milestone Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment