Build Nitrate as docker image #180

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@atodorov
Contributor

atodorov commented Apr 23, 2017

This PR makes it possible to build Nitrate as a Docker image and adds a docker compose to be able to execute the web app and the DB app together as 2 different containers. It also adds persistent volumes for upload storage and database data, which makes upgrades very easy. Also adds documentation.

Notes:

  1. Once this is merged I intend to make use of it and create integration tests with Python+Selenium and have them run as part of the Travis CI build
  2. The documentation part about running Nitrate into Google cloud engine (which uses Docker images) will need to be updated but I have to re-test into GCE with the new image first. This can be done in a stand alone PR
  3. We really need to decide which would be the recommended way to install and run Nitrate and clean up the docs a little bit. There are too many options which are kind of confusing, OTOH I really have no idea how everyone feels about running Docker containers inside their environment. I guess people wouldn't mind so we can designate Docker to be the official way of consuming Nitrate from now on.
Allow reading DB settings from environment
useful to configure a Docker image

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 23, 2017

Coverage Status

Coverage decreased (-0.004%) to 45.362% when pulling ed97432 on MrSenko:build_docker_image into a1c47ec on Nitrate:develop.

Coverage Status

Coverage decreased (-0.004%) to 45.362% when pulling ed97432 on MrSenko:build_docker_image into a1c47ec on Nitrate:develop.

Dockerize Nitrate and update documentation
the DB + Django app are configured as a docker compose.

To build the Nitrate docker image:

	make docker-image

this will automatically build and set version. By default the
image is tagged as nitrate/nitrate:<version>

To execute type:

	docker-compose up -d

Signed-off-by: Mr. Senko <atodorov@mrsenko.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 24, 2017

Coverage Status

Coverage decreased (-0.004%) to 45.362% when pulling e4330a0 on MrSenko:build_docker_image into a1c47ec on Nitrate:develop.

Coverage Status

Coverage decreased (-0.004%) to 45.362% when pulling e4330a0 on MrSenko:build_docker_image into a1c47ec on Nitrate:develop.

@tkdchen tkdchen added this to the 4.3 milestone Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment