Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandoc-placetable failure due to dependency on pandoc at setup #435

Closed
wants to merge 1 commit into from

Conversation

@unode
Copy link
Member

@unode unode commented Nov 15, 2019

Originally reported at: NixOS/nixpkgs#73392

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 15, 2019

@unode Thanks for sending a fix for this.

However, it appears I was incorrect about putting pandoc in library depends. It should actually be in the executable depends section.

Here's what the .nix file looks like when using cabal2nix to generate it for pandoc-placetable with this PR:

{ mkDerivation, aeson, base, bytestring, explicit-exception
, http-conduit, pandoc, pandoc-types, spreadsheet, stdenv, text
, utf8-string
}:
mkDerivation {
  pname = "pandoc-placetable";
  version = "0.5.1";
  sha256 = "22844b30fa5be4190e816de920d5bbbdccde18e4022c7927a97c4b83b0aed87d";
  configureFlags = [ "-finlineMarkdown" ];
  isLibrary = false;
  isExecutable = true;
  enableSeparateDataOutput = true;
  libraryHaskellDepends = [ pandoc ];
  executableHaskellDepends = [
    aeson base bytestring explicit-exception http-conduit pandoc-types
    spreadsheet text utf8-string
  ];
  homepage = "https://github.com/mb21/pandoc-placetable";
  description = "Pandoc filter to include CSV files";
  license = "GPL";
}

So it looks like it is working as expected, but pandoc needs to be in the executableHaskellDepends section.

@peti
Copy link
Member

@peti peti commented Nov 24, 2019

I believe that the underlying issue causing the missing dependency was fixed by 650d530?

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 24, 2019

@peti I believe you're correct.

NixOS/nixpkgs#74050 removes pandoc-placetable from the list of broken packages in nixpkgs.

So I think this PR can be closed.

@peti peti closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.