Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nix 2.3.4 #16

Merged
merged 1 commit into from May 6, 2020
Merged

Update to nix 2.3.4 #16

merged 1 commit into from May 6, 2020

Conversation

@prusnak
Copy link
Member

prusnak commented May 3, 2020

This change also includes an addition of ARG instruction, so the installed nix version could be easily changed via docker build --build-arg NIX_VERSION=<version>

Supersedes #14

@domenkozar
Copy link
Member

domenkozar commented May 5, 2020

@peti I'm not sure how you test Nix upgrades, but a simple nix-build -A git '<nixpkgs>' works with this commit and it would be good to merge this.

Copy link
Member

peti left a comment

👍 on the substance of the PR. 👎 on the seemingly arbitrary introduction of colons.

Dockerfile Outdated Show resolved Hide resolved
@peti
Copy link
Member

peti commented May 6, 2020

I'm not sure how you test Nix upgrades.

Travis-CI runs a test (and it's succeeding).

@peti peti self-assigned this May 6, 2020
This change also includes an addition of ARG instruction,
so the installed nix version could be easily changed via
docker build --build-arg NIX_VERSION=<version>
@domenkozar domenkozar requested a review from peti May 6, 2020
@peti peti merged commit d4965ab into NixOS:master May 6, 2020
2 checks passed
2 checks passed
ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prusnak prusnak deleted the prusnak:nix-2.3.4 branch May 6, 2020
@prusnak
Copy link
Member Author

prusnak commented May 6, 2020

Thanks peti for the merge and for pushing the updated container to Docker Hub!

Can we maybe also tag the container with 2.3.4 on Docker Hub?

@domenkozar
Copy link
Member

domenkozar commented May 6, 2020

@peti
Copy link
Member

peti commented May 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.