Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev env #574

Closed
wants to merge 1 commit into from
Closed

Improve dev env #574

wants to merge 1 commit into from

Conversation

@Ma27
Copy link
Member

Ma27 commented Jul 15, 2018

This PR contains two commits with the attempt to make bootstrapping and hacking on Hydra easier. Until now it missed to mention hydra-init and setting the env vars accordingly.

Please note that this PR is highly opinionated and it probably shouldn't merged as-is to master. However it may help other folks to get started with contributing to Hydra even faster.


Update from 2019-11-02 (after adding postgresql support):

This is basically stuff I found out during several times I contributed
minor things to Hydra. This patch adds several files to .gitignore to
ensure that one doesn't add random stuff accidentally to their commit.

Also improved the shellHook to set all required environment variables
and to check if there's a postgresql available (optionally one can start
a simple instance in a nixos-container using test-database.nix).

@Ma27 Ma27 force-pushed the Ma27:improve-dev-env branch from 536f676 to 0ae8b28 Nov 2, 2019
@Ma27
Copy link
Member Author

Ma27 commented Mar 7, 2020

@edolstra @grahamc is there anything to improve (or can we merge this)? IMHO this makes contributing to Hydra at least a bit easier :)

This is basically stuff I found out during several times I contributed
minor things to Hydra. This patch adds several files to `.gitignore` to
ensure that one doesn't add random stuff accidentally to their commit.

Also improved the shellHook to set all required environment variables
and to check if there's a postgresql available (optionally one can start
a simple instance in a nixos-container using `test-database.nix`).
@Ma27 Ma27 force-pushed the Ma27:improve-dev-env branch from 0386b06 to d0f8e29 Apr 17, 2020
@Ma27
Copy link
Member Author

Ma27 commented Apr 17, 2020

@edolstra from my PoV this helps contributors to set up a dev environment to hack on Hydra. Is there anything that keeps this from getting merged? :)

@andir
Copy link
Member

andir commented May 13, 2020

Just gave this a shot and ran into this:

$ nixos-container create hydradb --nixos-path "<nixpkgs/nixos>" --local-address 10.242.1.2 --host-address 10.242.1.1 --config-file test-database.nix
mkdir /etc/containers: Permission denied at /run/current-system/sw/bin/nixos-container line 105.

I guess that is expected but should probably documented.

@Ma27
Copy link
Member Author

Ma27 commented May 13, 2020

Oh yeah, there's a sudo missing, sorry for that.

@gilligan gilligan mentioned this pull request May 14, 2020
@gilligan
Copy link
Contributor

gilligan commented May 15, 2020

@Ma27 what is your input on #759 - would that work for you?

@gilligan
Copy link
Contributor

gilligan commented May 15, 2020

@Ma27 Thank you for your time/contribution, I was motivated by your work on this. However I am going to close this now that #759 has been closed.

@gilligan gilligan closed this May 15, 2020
@Ma27 Ma27 deleted the Ma27:improve-dev-env branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.