New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitlabPulls input plugin #592

Merged
merged 2 commits into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@nlewo
Copy link
Member

nlewo commented Sep 4, 2018

No description provided.

@nlewo nlewo force-pushed the nlewo:pr-gitlabpulls branch from e49e24d to 44470af Sep 4, 2018

@nlewo

This comment has been minimized.

Copy link
Member

nlewo commented Sep 27, 2018

cc @shlevy

@nlewo nlewo force-pushed the nlewo:pr-gitlabpulls branch from 44470af to 68aad22 Oct 15, 2018

@Shados

This comment has been minimized.

Copy link

Shados commented Nov 16, 2018

@nlewo in light of #512, I would suggest changing the plugin slightly to something like this.

This also includes support for using a personal access token (PAT) in order to access protected or private repositories. Using the target repository URL along with the merge-request ref instead of the source repository url and branch is necessary to avoid running into issues if the source repository is not actually accessible to the user Hydra is authenticating as. (EDIT: To clarify, that won't work out of the box for private or internal repos, you'd still need to add a valid auth token into the target_repo_url... gitlab's auth is kind of a pain)

I'm running this modified version of the plugin internally at work, and haven't had any issues thus far.

plugin/GitLabPulls: support for using a personal access token (PAT)
In order to access protected or private repositories. Using the target
repository URL along with the merge-request ref instead of the source
repository url and branch is necessary to avoid running into issues if
the source repository is not actually accessible to the user Hydra is
authenticating as.

Thanks Alexei Robyn for this patch.
@nlewo

This comment has been minimized.

Copy link
Member

nlewo commented Nov 28, 2018

@Shados Thanks for your patch. I applied it and it works well.
@edolstra Could you please take a look?

@Ericson2314 Ericson2314 referenced this pull request Jan 5, 2019

Open

Gitlab support #606

@Ericson2314

This comment has been minimized.

Copy link
Member

Ericson2314 commented Jan 11, 2019

I have now used this and can confirm is does the thing. Please merge!

@shlevy shlevy merged commit d925354 into NixOS:master Jan 11, 2019

@Ericson2314

This comment has been minimized.

Copy link
Member

Ericson2314 commented Jan 11, 2019

Thanks @shlevy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment