Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github notifications for evals #712

Open
wants to merge 1 commit into
base: master
from

Conversation

@pikajude
Copy link

@pikajude pikajude commented Feb 6, 2020

Eval notifications are nice. This makes status not get stuck if an evaluation fails.

@pikajude pikajude requested a review from basvandijk Feb 6, 2020
@knl
Copy link
Contributor

@knl knl commented Mar 16, 2020

Maybe it would be good to have unified eval context (instead of one being named after the PR), so one could turn on branch protection on the context being successful.

Implemented in: pikajude#1

}
};
if ($@) {
print STDERR "error processing message '$payload' on channel '$channelName': $@\n";
}

This comment has been minimized.

@knl

knl May 21, 2020
Contributor

I don't think this is needed. My understanding is that it's used for the test, and I wrote in the test how one can do it differently, alleviating the need for once.

@@ -88,6 +127,10 @@ for my $build ($db->resultset('Builds')->search(
my $buildId = $build->id;
print STDERR "sending notifications for build ${\$buildId}...\n";
buildFinished($build);

This comment has been minimized.

@knl

knl May 21, 2020
Contributor

I don't think this is needed. My understanding is that it's used for the test, and I wrote in the test how one can do it differently, alleviating the need for once.

my $output = $machine->mustSucceed("hydra-notify --once 2>&1");
$output =~ m!GithubStatus_Debug POSTing to.*repos/run/jobset/statuses!
or die "GithubStatus plugin did not activate";
Comment on lines +367 to +369

This comment has been minimized.

@knl

knl May 21, 2020
Contributor

Suggested change
my $output = $machine->mustSucceed("hydra-notify --once 2>&1");
$output =~ m!GithubStatus_Debug POSTing to.*repos/run/jobset/statuses!
or die "GithubStatus plugin did not activate";
$machine->waitUntilSucceeds("journalctl -u hydra-notify.service | grep -G 'GithubStatus_Debug POSTing to.*repos/run/jobset/statuses'");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.