Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "hydra-queue-runner: Support running in a NixOS container" #754

Open
wants to merge 1 commit into
base: master
from

Conversation

@basvandijk
Copy link
Member

basvandijk commented May 11, 2020

This reverts commit d4b4255 which caused builds on the localhost builder to build all dependencies of preferLocalBuild derivations as well. It was suggested by @AmineChikhaoui to revert that commit to fix this and I can confirm it indeed fixes it.

@edolstra I expect you to have a better solution for this but I didn't understand the code well enough to know what to revert and what to leave so I just reverted the whole of d4b4255. See this more as a starting point of a conversation on how to properly fix this.

This reverts commit d4b4255.

That commit caused builds on the localhost builder to build all
dependencies of `preferLocalBuild` derivations as well. It was
[suggested](#749 (comment))
to revert that commit to fix this and I can confirm it indeed fixes it.
@basvandijk basvandijk requested a review from edolstra May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.