Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all tests to the Python DSL #755

Merged
merged 1 commit into from May 11, 2020

Conversation

@knl
Copy link
Contributor

knl commented May 11, 2020

Since Perl-based NixOS tests will be deprecated in nixpkgs 20.09, this
change migrates all tests to the new Python-based NixOS tests.

@basvandijk
Copy link
Member

basvandijk commented May 11, 2020

@knl apparently the Pytnon formatter doesn't like uncessary empty lines:

$ nix-build -A hydraJobs.tests.api.x86_64-linux
these derivations will be built:
  /nix/store/hvdc9pkwln91pm975aj09mlpg9apqsvc-nixos-test-driver-unnamed.drv
  /nix/store/bkpqkkl1cda3a4xr8dv77m0rnf6l5rql-vm-test-run-unnamed.drv
building '/nix/store/hvdc9pkwln91pm975aj09mlpg9apqsvc-nixos-test-driver-unnamed.drv'...
--- /nix/store/ipcl7ry7llfwvp3v2kpv1fn7zsg9kcmx-nixos-test-driver-unnamed/test-script   2020-05-11 20:01:43.996430 +0000
+++ /nix/store/ipcl7ry7llfwvp3v2kpv1fn7zsg9kcmx-nixos-test-driver-unnamed/test-script   2020-05-11 20:01:44.143875 +0000
@@ -19,6 +19,5 @@
 # Run the API tests.
 machine.succeed(
     "su - hydra -c 'perl -I /nix/store/wz6ksf0zx9avcngw96scp871ifnygk4i-hydra-perl-deps/lib/perl5/site_perl /nix/store/ivcn5yaj5vxzxgarp6ap40cny3w3yiy4-api-test.pl' >&2"
 )

-
would reformat /nix/store/ipcl7ry7llfwvp3v2kpv1fn7zsg9kcmx-nixos-test-driver-unnamed/test-script
Oh no! 💥 💔 💥
1 file would be reformatted.
Since Perl-based NixOS tests will be deprecated in nixpkgs 20.09, this
change migrates all tests to the new Python-based NixOS tests.
@knl knl force-pushed the knl:migrate-tests-to-the-python-DSL branch from 619eaaa to 3efa822 May 11, 2020
Copy link
Member

basvandijk left a comment

Looks good and all tests still succeed. Thanks!

@basvandijk basvandijk merged commit c2bc84d into NixOS:master May 11, 2020
2 checks passed
2 checks passed
tests
Details
validate-openapi
Details
@knl knl deleted the knl:migrate-tests-to-the-python-DSL branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.