Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitInput: only convert integer option values to int #756

Merged

Conversation

@basvandijk
Copy link
Member

basvandijk commented May 13, 2020

The previous code converted option values to ints when the value contained a digit somewhere. This is too eager since it also converts strings like release-0.2 to an int which should not happen.

We now only convert to int when the value is an integer.

The previous code converted option values to ints when the value
contained a digit somewhere. This is too eager since it also converts
strings like `release-0.2` to an int which should not happen.

We now only convert to int when the value is an integer.
@basvandijk basvandijk merged commit 301e4e0 into NixOS:master May 13, 2020
2 checks passed
2 checks passed
tests
Details
validate-openapi
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.