Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Render the jobset page correctly when there are fetch errors #764
The original code would return standard "Please come back later" page when there
This change includes using 'lastchecktime' when rendering the error times.
The original code would return standard "Please come back later" page when there are only fetch errors on a newly setup declarative project. The problem is that there are two types of errors: standard errors and fetch errors. Each is acompanied by a corresponding field for time of occurence. Standard errors use 'errortime', while fetch errors have 'lastchecktime' set to the time of the error. Unfortunately, jobset.tt file was only using 'errortime' for displaying the time. This would result in the following errors in logs: Couldn't render template "date error - bad time/date string: expects 'h
Ⓜ️s d Ⓜ️y' got: '' This change includes using 'lastchecktime' when rendering the error times.