channel updates: make sequential #80
Conversation
grahamc
force-pushed
the
fix-79/make-channel-updates-sequential
branch
from
a6862fb to
e70b715
Compare
modules/service-order.nix
Outdated
| # | ||
| # Given a set of services, make them run one at a time in a specific | ||
| # order, on a timer. | ||
| { lib, ... }: |
There was a problem hiding this comment.
Any reason to allow additional arguments here?
Since this is an attrset that isn't importable as a module, this doesn't really make sense to me as is. Was this initially started considering it could be implemented as a NixOS module? Could it be made one? Otherwise, would it make make more sense at a location like ../lib or ./lib?
There was a problem hiding this comment.
+1 that was sloppy of me
grahamc
force-pushed
the
fix-79/make-channel-updates-sequential
branch
from
e70b715 to
798deef
Compare
Create a sequential ordering with systemd After-relationships between each channel's update job. Then, remove individual timers and create one timer for all the jobs. Fixes #79
grahamc
force-pushed
the
fix-79/make-channel-updates-sequential
branch
from
798deef to
5c3362d
Compare
|
Deployed! |
|
Wouldn't it be easier to just have a shell script that runs |
|
I had considered that, but thought it much nicer to be able to start them individually if we have need to, plus have individual logs and result statuses. Would you prefer I replace this with the simpler approach? |
|
Yeah you're right, it's nice to have individual control over the units. |
Create a sequential ordering with systemd After-relationships between
each channel's update job. Then, remove individual timers and create
one timer for all the jobs.
Fixes #79